Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cve 2016 0808 #136

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

giantpune
Copy link
Contributor

based off #134

  • not adding in details for vulns from 2009 that were fixed in gingerbread. This app won't install or run on those phones. minimum SDK is 15 (Android 4.0.3)
  • use java and KMPMatch to perform the search rather than adding a native library for each supported architecture

@m00head
Copy link
Contributor

m00head commented Aug 13, 2016

The required changes to the following files are missing from this PR:
app/src/main/jni/Android.mk
app/src/main/jni/cve20160808.c

See 'Files changed' tab on #134 for details.

You have also removed the following vulns from the change, but they are not from 2009:
CVE-2012-6422
CVE-2011-1350
CVE-2012-0056

@giantpune
Copy link
Contributor Author

I removed the JNI files because the check is implemented now in java. I'll have to go back and check on the dates. But I don't think this app will install on any device with a 2011 build date. 2012 might still be relevant.

@m00head
Copy link
Contributor

m00head commented Mar 28, 2017

Looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants