Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce system/phase timers #186

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Conversation

AndreasLrx
Copy link
Owner

Description

Everything (soon) in the doc.

Close: #181

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Added/updated tests?

  • New tests written
  • Existing tests updated
  • Tests are not required because this is a documentation update
  • I need help with writing tests

@AndreasLrx AndreasLrx added the system Related to ecstasy systems label Nov 22, 2024
@AndreasLrx AndreasLrx self-assigned this Nov 22, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 91.11111% with 4 lines in your changes missing coverage. Please review.

Project coverage is 82.36%. Comparing base (e1fcd84) to head (63b3d35).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/ecstasy/system/Timer.cpp 91.66% 2 Missing and 1 partial ⚠️
src/ecstasy/system/Pipeline.cpp 75.00% 0 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #186      +/-   ##
==========================================
+ Coverage   82.18%   82.36%   +0.18%     
==========================================
  Files          68       70       +2     
  Lines        1201     1242      +41     
  Branches      371      383      +12     
==========================================
+ Hits          987     1023      +36     
- Misses        145      148       +3     
- Partials       69       71       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@AndreasLrx AndreasLrx force-pushed the feature/181-systems-scheduler branch 2 times, most recently from a970de0 to 4714dff Compare November 22, 2024 15:43
@AndreasLrx AndreasLrx force-pushed the feature/181-systems-scheduler branch from 4714dff to 63b3d35 Compare November 22, 2024 15:54
@AndreasLrx AndreasLrx merged commit 4f4cb2a into main Nov 22, 2024
4 checks passed
@AndreasLrx AndreasLrx deleted the feature/181-systems-scheduler branch November 22, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
system Related to ecstasy systems
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] System scheduler
2 participants