Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce new system Pipeline behavior #185

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Conversation

AndreasLrx
Copy link
Owner

Description

Introduce System Pipelines and Phases to have better control of system execution order.
This will be improved with #181

Close: #184

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

[optional] Minor fixes

Added/updated tests?

  • New tests written
  • Existing tests updated
  • Tests are not required because this is a documentation update
  • I need help with writing tests

@AndreasLrx AndreasLrx added the system Related to ecstasy systems label Nov 21, 2024
@AndreasLrx AndreasLrx self-assigned this Nov 21, 2024
@AndreasLrx AndreasLrx force-pushed the feature/184-system-pipeline branch 4 times, most recently from 74422f5 to ec627ef Compare November 21, 2024 15:58
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 70.68966% with 17 lines in your changes missing coverage. Please review.

Project coverage is 82.18%. Comparing base (19680ae) to head (414ba23).

Files with missing lines Patch % Lines
src/ecstasy/system/Pipeline.cpp 69.56% 7 Missing and 7 partials ⚠️
src/ecstasy/registry/Registry.hpp 0.00% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #185      +/-   ##
==========================================
+ Coverage   82.13%   82.18%   +0.04%     
==========================================
  Files          67       68       +1     
  Lines        1159     1201      +42     
  Branches      361      371      +10     
==========================================
+ Hits          952      987      +35     
  Misses        145      145              
- Partials       62       69       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@AndreasLrx AndreasLrx merged commit e1fcd84 into main Nov 22, 2024
4 checks passed
@AndreasLrx AndreasLrx deleted the feature/184-system-pipeline branch November 22, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
system Related to ecstasy systems
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] System pipelines
2 participants