BREAKING CHANGE: ecstasy::ResourceReference now use std::reference_wrapper #177
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TL;DR;
Old behavior:
New behavior:
Explanations
And added a
get
method in theLockableView
, equivalent to the one of thestd::reference_wrapper
. This means all ResourceReference need to useget()
to access the underlying resource, regardless of the thread safe variable.The previous way was to always use the arrow operator
->
, which was defined in the templatedResource
class but it wasn't a good idea because it breaks when the underlying type also define the->
arrow operator (such asObjectWrapper
, which was used by the sfml and was causing the initial issue #170).Therefore this behavior was deleted:
Resource<>
andResourceBase
are now a single basicIResource
with nothing in it (still required as a type erasure way to store the resources in the same container)Close #170
What type of PR is this? (check all applicable)
[optional] Minor fixes
Fix #174 not running build CI AT ALL
Added/updated tests?