Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken sample code in README.md #168

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Fix broken sample code in README.md #168

merged 1 commit into from
Oct 17, 2024

Conversation

osvegn
Copy link
Contributor

@osvegn osvegn commented Oct 17, 2024

Description

Add missing include <ecstasy/storages/MapStorage.hpp> in README.md
Update entityBuilder in README.md

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Added/updated tests?

  • New tests written
  • Existing tests updated
  • Tests are not required because this is a documentation update
  • I need help with writing tests

@AndreasLrx
Copy link
Owner

Thanks for the contribution,
While you're fixing this, can you also fix it in the Tutorial.md please ?

@AndreasLrx AndreasLrx mentioned this pull request Oct 17, 2024
Closed
@AndreasLrx AndreasLrx added the documentation Improvements or additions to documentation label Oct 17, 2024
@osvegn
Fix broken sample code in README.md and Tutorial.md
fa9d54a 
Add missing include <ecstasy/storages/MapStorage.hpp>
Update entityBuilder
@AndreasLrx AndreasLrx merged commit bb3b96a into AndreasLrx:main Oct 17, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@osvegn osvegn

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@osvegn @AndreasLrx