Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/150 entity serialization #158

Merged
merged 8 commits into from
Sep 12, 2024
Merged

Conversation

AndreasLrx
Copy link
Owner

@AndreasLrx AndreasLrx commented Jul 15, 2024

Description

Introduce a new serializer able to serialize an entire entity and its components. Either from the list of components explicitly or taking all entity components.

This is working but I'm not satisfied of the implementation and will certainly get a huge refactoring when I find a better solution.

Close #150

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

[optional] Minor fixes

Fix FindToml++ file.

Added/updated tests?

  • New tests written
  • Existing tests updated
  • Tests are not required because this is a documentation update
  • I need help with writing tests

@AndreasLrx AndreasLrx added enhancement New feature or request serialization labels Jul 15, 2024
@AndreasLrx AndreasLrx added this to the ECS Serialization milestone Jul 15, 2024
@AndreasLrx AndreasLrx self-assigned this Jul 15, 2024
@AndreasLrx AndreasLrx force-pushed the feature/150-entity-serialization branch 6 times, most recently from 43acf44 to b5f0bd8 Compare July 16, 2024 08:29
@codecov-commenter
Copy link

codecov-commenter commented Jul 16, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 82.23%. Comparing base (42c5b14) to head (fc8e62d).

Files with missing lines Patch % Lines
src/ecstasy/storages/MapStorage.hpp 0.00% 3 Missing ⚠️
src/ecstasy/storages/AStorage.hpp 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #158      +/-   ##
==========================================
- Coverage   82.75%   82.23%   -0.53%     
==========================================
  Files          63       64       +1     
  Lines        1096     1103       +7     
  Branches      349      353       +4     
==========================================
  Hits          907      907              
- Misses        133      140       +7     
  Partials       56       56              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AndreasLrx AndreasLrx force-pushed the feature/150-entity-serialization branch 5 times, most recently from 8a6d3d6 to 45d223f Compare July 16, 2024 14:46
@AndreasLrx AndreasLrx force-pushed the feature/150-entity-serialization branch 3 times, most recently from f74c759 to 9498edf Compare September 12, 2024 14:26
@AndreasLrx AndreasLrx force-pushed the feature/150-entity-serialization branch from 9498edf to fc8e62d Compare September 12, 2024 14:27
@AndreasLrx AndreasLrx merged commit e23abcc into main Sep 12, 2024
4 checks passed
@AndreasLrx AndreasLrx deleted the feature/150-entity-serialization branch September 12, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request serialization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(De)Serialize an Entity with user defined serialization method
2 participants