Elastic search assets and users 165965388 #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmazi
reviewed
Jul 23, 2019
api/tests/test_asset_api.py
Outdated
| @@ -387,3 +387,63 @@ def test_asset_allocation_history_has_assigner(self, mock_verify_id_token): | |||
| ) | |||
| self.assertIn("assigner", response.data["allocation_history"][0].keys()) | |||
| self.assertEqual(response.status_code, 200) | |||
|
|
|||
| @patch("api.authentication.auth.verify_id_token") | |||
| def test_asset_search_endpoint(self, mock_verify_id_token): | |||
There was a problem hiding this comment.
Asset search is more of a functionality than an endpoint. However, there's an asset endpoint. A better description could be, "test_search_funx_on_asset_endpoint".
kmazi
requested changes
Jul 23, 2019
| response.data.get('results')[0].get('uuid'), str(asset_two.uuid) | ||
| ) | ||
|
|
||
| response = client.get( |
There was a problem hiding this comment.
It would be more appropriate if the tests are independent to show different functionalities rather than grouping them together. Different tests cases could should show different fields the search query string reaches.
There was a problem hiding this comment.
The test objects created could be done in a helper function/method and called when need be.
kmazi
force-pushed
the
elastic-search-assets-and-users-165965388
branch
from
d2b419c
to
52bc506
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Allow full text search across different fields from the viewset
Description of Task to be completed?
How should this be manually tested?
Any background context you want to provide?
What are the relevant pivotal tracker stories?
https://www.pivotaltracker.com/n/projects/2146417/stories/165965388
Postman Documentation
Screenshots (If applicable)