refactor: new feature structure #572
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Centralised and simplified the product module's file structure. Moved models and functions to their respective directories and unified export through a single `product.dart` barrel file. This change makes imports cleaner across the codebase and eases future development as all product-related components and models are now accessible from a single import point. Resolves: #12345 (if there's a relevant issue to link)
Add a new export file inside the features folder that points towards the new location of the product feature folder in src. This ensures that the developer always imports the barrel file when auto-importing for a better DX.
todo: fix naming is tests
- fix test names & clean up tests - changed tests to generate nice mocks - add test util for matching against a request's auth header - remove the need for GetIt mocking in retry_authenticator_test - changed throttler extension to return task instead of future - add withMinimumDuration extension method on Task - add getAuthenticationToken method in repository - refactor AuthenticationInterceptor.onRequest - hugely simplify RetryAuthenticator - add withBearerToken extension method on Request - rename repository.dart to repository_test.dart
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #572 +/- ##
===========================================
- Coverage 68.76% 48.95% -19.82%
===========================================
Files 133 168 +35
Lines 1697 2482 +785
===========================================
+ Hits 1167 1215 +48
- Misses 530 1267 +737
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
adds tests to this new class
refactor contributor feature fix authentication store remove upgrader library
marfavi
force-pushed
the
new-feature-structure
branch
from
32286a2
to
7a2f236
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.