Group urlname configurable [issue #45] #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- abstracted the AbstractService::__constructor() - abstracted common methods: AbstractService::getApi(), AbstractService::getCache()
|
|
||
| # IDE | ||
| .idea/ |
There was a problem hiding this comment.
your personal files,like IDE choice, should be excluded using git's global config (http://stackoverflow.com/questions/7335420/global-git-ignore)
There was a problem hiding this comment.
Agreed. Would also be better as a separate PR if it would be valid.
#46: Better API failover
|
Please update your branch with the latest changes, otherwise we'll be unable to merge it. |
- abstracted the AbstractService::__constructor() - abstracted common methods: AbstractService::getApi(), AbstractService::getCache() - no changes to .gitignore Conflicts: src/AmsterdamPHP/Bundle/MeetupBundle/Service/EventService.php
pascaldevink
pushed a commit
that referenced
this pull request
Nov 22, 2014
Group urlname configurable [issue #45]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #45
*Serviceclasses.gitignore