Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Gengar): Hide Summary section unless populated #2010

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 11 additions & 17 deletions apps/artboard/src/templates/gengar.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -82,17 +82,19 @@ const Header = () => {

const Summary = () => {
const section = useArtboardStore((state) => state.resume.sections.summary);

const primaryColor = useArtboardStore((state) => state.resume.metadata.theme.primary);
if (!section.visible || isEmptyString(section.content)) return null;

return (
<section id={section.id}>
<div
dangerouslySetInnerHTML={{ __html: section.content }}
className="wysiwyg"
style={{ columns: section.columns }}
/>
</section>
<div className="p-custom space-y-4" style={{ backgroundColor: hexToRgb(primaryColor, 0.2) }}>
<section id={section.id}>
<div
dangerouslySetInnerHTML={{ __html: section.content }}
className="wysiwyg"
style={{ columns: section.columns }}
/>
</section>
</div>
);
};

Expand Down Expand Up @@ -600,15 +602,7 @@ export const Gengar = ({ columns, isFirstPage = false }: TemplateProps) => {
</div>

<div className="main group col-span-2">
{isFirstPage && (
<div
className="p-custom space-y-4"
style={{ backgroundColor: hexToRgb(primaryColor, 0.2) }}
>
<Summary />
</div>
)}

{isFirstPage && <Summary />}
<div className="p-custom space-y-4">
{main.map((section) => (
<Fragment key={section}>{mapSectionToComponent(section)}</Fragment>
Expand Down