-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed Overlapping LocaleSwitch & ThemeSwitch Button #1634 #1635
Conversation
Bumps [@adobe/css-tools](https://github.com/adobe/css-tools) from 4.3.1 to 4.3.2. - [Changelog](https://github.com/adobe/css-tools/blob/main/History.md) - [Commits](https://github.com/adobe/css-tools/commits) --- updated-dependencies: - dependency-name: "@adobe/css-tools" dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
Hey there, thank you for the contribution. Could you also share a quick screenshot of how it looks now after your changes VS how it looked before? This would help me in reviewing the PR much quicker. |
I actually would like to see the language and theme picker next to the logo no matter what page you're on. So it can be consistent across all auth pages. If you could make that change, it would be awesome. By the way, you're doing great with the code contributions, the code is written perfectly and I really do appreciate that :) Thank you so much for all your help. |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit aa8a8e3. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ⌛ The following targets are in progress
✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
Just added -mt-12 in auth/layout.tsx
GitHub and Google Authentication buttons were overlapping the LocaleSwitch & ThemeSwitch buttons.
P.s. Ignore the commit history. First time creating the professional PR.