Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Overlapping LocaleSwitch & ThemeSwitch Button #1634 #1635

Merged
merged 12 commits into from
Dec 6, 2023

Conversation

MYSTYX7
Copy link
Contributor

@MYSTYX7 MYSTYX7 commented Dec 2, 2023

Just added -mt-12 in auth/layout.tsx

GitHub and Google Authentication buttons were overlapping the LocaleSwitch & ThemeSwitch buttons.

P.s. Ignore the commit history. First time creating the professional PR.

@AmruthPillai
Copy link
Owner

Hey there, thank you for the contribution.

Could you also share a quick screenshot of how it looks now after your changes VS how it looked before? This would help me in reviewing the PR much quicker.

@MYSTYX7
Copy link
Contributor Author

MYSTYX7 commented Dec 4, 2023

image Login Page before

image Login Page now (1st Revision)

But I realized that it's not aligning with Registration Page also in both codes.. And there isn't much space in the screen to align in the same layout, so in the latest commit, I've aligned both the switches similar to the Mobile View because that top-right corner was empty as well.

image Registration Page before

image Registration Page now (2nd Revision)

P.s. Sorry for the PR closed, still getting to know about all these PR and Issue things.

@MYSTYX7 MYSTYX7 reopened this Dec 4, 2023
@AmruthPillai
Copy link
Owner

I actually would like to see the language and theme picker next to the logo no matter what page you're on. So it can be consistent across all auth pages. If you could make that change, it would be awesome.

By the way, you're doing great with the code contributions, the code is written perfectly and I really do appreciate that :) Thank you so much for all your help.

@MYSTYX7
Copy link
Contributor Author

MYSTYX7 commented Dec 4, 2023

Yes, It's consistent on all auth pages in current PR and next commit is ready to implement these switches in Dashboard Sidebar as well if you want to make it more consistent.

image Login Page

image Registration Page (Commit till now)

image Dashboard Sidebar (Currently Live)

image Dashboard Sidebar (Latest commit ready)

@AmruthPillai AmruthPillai merged commit f54890d into AmruthPillai:main Dec 6, 2023
2 checks passed
Copy link

nx-cloud bot commented Dec 6, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit aa8a8e3. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


⌛ The following targets are in progress

✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants