Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change np.NaN to np.nan #82

Merged
merged 3 commits into from
Oct 8, 2024
Merged

change np.NaN to np.nan #82

merged 3 commits into from
Oct 8, 2024

Conversation

ioalexei
Copy link
Contributor

@ioalexei ioalexei commented Oct 2, 2024

Testing this threw an error using numpy 2.0, which says np.NaN has been replaced by np.nan

@ioalexei
change np.NaN to np.nan
a216e30 
Testing this threw an error using numpy 2.0, which says np.NaN has been replaced by np.nan
@danbjoseph danbjoseph requested a review from jayqi October 2, 2024 18:04
jayqi
jayqi requested changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@jayqi jayqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably should've caught this earlier, but equality comparisons with an explicit NaN object is not the right way to do this. Geopandas (inherited from regular Pandas) has isna and notna methods that we should use instead.

@jayqi jayqi merged commit df8e557 into main Oct 8, 2024
3 checks passed
@jayqi jayqi deleted the svgv-assign_images-np.nan branch October 8, 2024 17:56
@danbjoseph
Copy link
Member

Thank you @ioalexei and @jayqi !
🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayqi jayqi jayqi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ioalexei @danbjoseph @jayqi