-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: create_points.py unit tests #74
tests: create_points.py unit tests #74
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall well done, but a few changes could be made, mostly nitpicks 🎉
Also, changing your commit message to follow Conventional Commits is preferred |
Sorry for how long this is taking, I just started a new job and moved but things should settle down soon and I can give more time to this project! |
No worries about the time commitment, we're all doing our best in the off time we have lol |
Awesome, thank you @alissawang! Your contribution is greatly appreciated! And thank you to @dragonejt for reviewing! |
Unit tests for
create_points.py
with the creation of anassets
directory to hold test data.Not the most familiar with geodata so let me know if there are edge cases I missed!
Closes #49