Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: create_points.py unit tests #74

Merged
merged 4 commits into from
Sep 20, 2024

Conversation

alissawang
Copy link
Contributor

@alissawang alissawang commented Aug 14, 2024

Unit tests for create_points.py with the creation of an assets directory to hold test data.

Not the most familiar with geodata so let me know if there are edge cases I missed!

Closes #49

Copy link
Contributor

@dragonejt dragonejt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall well done, but a few changes could be made, mostly nitpicks 🎉

tests/test_create_points.py Show resolved Hide resolved
tests/test_create_points.py Outdated Show resolved Hide resolved
tests/test_create_points.py Show resolved Hide resolved
tests/test_create_points.py Outdated Show resolved Hide resolved
tests/test_create_points.py Outdated Show resolved Hide resolved
tests/assets/test_gdf.shp Outdated Show resolved Hide resolved
tests/test_create_points.py Outdated Show resolved Hide resolved
@dragonejt
Copy link
Contributor

Also, changing your commit message to follow Conventional Commits is preferred

@alissawang
Copy link
Contributor Author

Sorry for how long this is taking, I just started a new job and moved but things should settle down soon and I can give more time to this project!

tests/test_create_points.py Show resolved Hide resolved
@dragonejt
Copy link
Contributor

Sorry for how long this is taking, I just started a new job and moved but things should settle down soon and I can give more time to this project!

No worries about the time commitment, we're all doing our best in the off time we have lol

@jayqi jayqi merged commit a51433d into AmericanRedCross:main Sep 20, 2024
3 checks passed
@danbjoseph
Copy link
Member

Awesome, thank you @alissawang! Your contribution is greatly appreciated! And thank you to @dragonejt for reviewing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write unit tests for create_points
4 participants