-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sdk): exported Angular and Beacon client to dedicated package #2183
Conversation
8d16be9
to
b515950
Compare
b515950
to
3be71e1
Compare
3be71e1
to
e0192bb
Compare
deprecate(sdk): the beacon and angular clients from @ama-sdk/core
e0192bb
to
81db4d1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you document this change in the next major version migration guide?
Why? |
In the v12 migration guide I would expect some words about this change: the list of deprecations mentioning that they will be removed in v13 and the fact that Users don't have to wait v13 until the interfaces will be removed, they can migrate to the new ones in v12. This is why I find this info useful in the v12 migration guide. |
I disagree on proposal to create migration v12 in this PR for the following reasons:
If you want to propose this, you can put it in the agenda of the next discussion session. |
Proposed change
Split of Angular and Beacon API Client to their own dedicated package
Related issues