Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: Turn SDK Mock API to ApiClient agnostic implementation #2117

Open
kpanot opened this issue Sep 2, 2024 · 0 comments · May be fixed by #2329
Open

[Feature]: Turn SDK Mock API to ApiClient agnostic implementation #2117

kpanot opened this issue Sep 2, 2024 · 0 comments · May be fixed by #2329
Labels
enhancement New feature or request priority:medium

Comments

@kpanot
Copy link
Contributor

kpanot commented Sep 2, 2024 •
edited by pginoux-1A
Loading

Context

In the current implementation the generated api-mock.ts in the SDK imports the ApiFetchClient.
To be able to fully support the multi client strategy, the api-mock.ts file should be ApiClient agnostic.

Proposal

  • Change the implementation of the file to factory requiring the ApiClient
  • Remove the Optional PeerDependency to @ama-sdk/client-fetch from the SDK shell.
  • Remove the Optional PeerDependency to isomorphic-fetch from the SDK shell.
@kpanot kpanot added enhancement New feature or request breaking change This issue or pull request introduces a breaking change labels Sep 2, 2024
@kpanot kpanot mentioned this issue Sep 2, 2024
Merged
@kpanot kpanot mentioned this issue Sep 4, 2024
Closed
6 tasks
This was referenced Sep 25, 2024
Merged
Merged
cpaulve-1A added a commit that referenced this issue Oct 2, 2024
@cpaulve-1A
fix(sdk-core): rollback api-mock.ts to use deprecate fetch client fro…
06939a6 
…m core (#2212)

## Proposed change

Rollback `api-mock.ts` to use deprecate fetch client from core.
This change will be part of #2117.

<!-- Please include a summary of the changes and the related issue.
Please also include relevant motivation and context. List any
dependencies that is required for this change. -->

## Related issues

- 🔗  Related to: #2117 

<!-- Please make sure to follow the contributing guidelines on
https://github.com/amadeus-digital/Otter/blob/main/CONTRIBUTING.md -->
This was referenced Oct 23, 2024
Draft
Merged
github-merge-queue bot pushed a commit that referenced this issue Oct 24, 2024
@kpanot
deprecate(sdk-generator): default client api based mocks (#2336)
6be9ef7 
## Proposed change

<!-- Please include a summary of the changes and the related issue.
Please also include relevant motivation and context. List any
dependencies that is required for this change. -->

deprecate the default client api based mocks in SDK generated mocks

## Related issues

- 🚀 Feature #2117

<!-- Please make sure to follow the contributing guidelines on
https://github.com/amadeus-digital/Otter/blob/main/CONTRIBUTING.md -->
@kpanot kpanot removed the breaking change This issue or pull request introduces a breaking change label Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request priority:medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(ama-sdk-schematics): remove dependencies in mock api generation AmadeusITGroup/otter
3 participants
@kpanot @matthieu-crouzet @pginoux-1A