Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove all duplicated logic, move all macroses and query parsing functionality to golang, and compile golang parser to WASM #690

Open
wants to merge 78 commits into
base: master
Choose a base branch
from
Open

remove all duplicated logic, move all macroses and query parsing functionality to golang, and compile golang parser to WASM #690

wants to merge 78 commits into from

Conversation

lunaticusgreen
Copy link
Collaborator

@lunaticusgreen lunaticusgreen commented Dec 10, 2024 •
edited by Slach
Loading

fix #688

@lunaticusgreen
refactored structure and move two methods to datasource.ts
14d0910
@lunaticusgreen
move scanner dependencies to one place
845b46d
@lunaticusgreen
add backend replace implementation
1a1c6b9
@lunaticusgreen
add backend replace implementation
8738583
@lunaticusgreen
add backend replace implementation
8765a74
@lunaticusgreen
change replace to endpoint request
fd3cb98
@lunaticusgreen
Finalize migration of sql_query
d556272
@lunaticusgreen
remove sql-query-macros.ts
b150ac2
@lunaticusgreen
cleanup tests
7ab94be
@lunaticusgreen
sql-query-helper.ts remove unused methods
4d4b479
@lunaticusgreen
Deprecate modifyQuery method, it wasn't used and was replaced with to…
409441d 
…ggleQueryFilter
@lunaticusgreen
get rid of unnecessary use of scanner.raw()
10e8b41
@lunaticusgreen
refactoring
a3fe164
@lunaticusgreen
move adhocs processing to backend
f9614b4
@lunaticusgreen
remove scanner.ts
185d08b
@lunaticusgreen
cleanup SQLQueryHelper imports
43bcc1b
@lunaticusgreen
Add replace time filter function to backend
6c94ddb
@lunaticusgreen
Remove SQL query helper
e9dc130
@lunaticusgreen
Merge branch 'master' into v4
4d29222 
# Conflicts:
#	src/datasource/frontend-only/sql-series/toAnnotation.test.ts
#	src/datasource/sql-query/sql-query-macros.ts
#	src/datasource/sql-query/sql_query.ts
#	src/spec/query_specs.jest.ts
#	src/spec/sql_series_specs.jest.ts
@lunaticusgreen
move replace.go to separate directory
c1cdde4
@lunaticusgreen
move resource handlers to separate directories
c05c6bb
@lunaticusgreen
Fixed lost tests
81409e9
@lunaticusgreen
move to observable
70ce512
@lunaticusgreen
rework query to support observable + remove deprecated tests
8930f76
@lunaticusgreen
remove unused packages
25c0420
@lunaticusgreen
remove temporary directory
78142d7
@lunaticusgreen
more refactoring
d52c235
@lunaticusgreen
fix interval parsing
bc7861a
@Slach Slach self-requested a review December 11, 2024 07:41
@Slach Slach added this to the 3.4.0 milestone Dec 11, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12363460870

Details

  • 331 of 699 (47.35%) changed or added relevant lines in 12 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-3.6%) to 72.177%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/eval_query.go 42 46 91.3%
src/datasource/backend-resources/backendResources.ts 8 12 66.67%
pkg/datasource.go 18 24 75.0%
src/datasource/datasource.ts 46 59 77.97%
pkg/resource_handler_replace_time_filters.go 37 56 66.07%
pkg/resource_handler_get_complete_ast.go 0 31 0.0%
pkg/resource_create_query.go 76 110 69.09%
pkg/resource_handler_get_ast_property.go 0 47 0.0%
pkg/resource_handler_apply_adhoc_filters.go 87 141 61.7%
src/datasource/helpers/index.ts 14 83 16.87%
Files with Coverage Reduction New Missed Lines %
src/datasource/datasource.ts 1 62.57%
Totals Coverage Status
Change from base Build 12278256209: -3.6%
Covered Lines: 2904
Relevant Lines: 3929
💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12363460870

Details

  • 331 of 699 (47.35%) changed or added relevant lines in 12 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-3.6%) to 72.177%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/eval_query.go 42 46 91.3%
src/datasource/backend-resources/backendResources.ts 8 12 66.67%
pkg/datasource.go 18 24 75.0%
src/datasource/datasource.ts 46 59 77.97%
pkg/resource_handler_replace_time_filters.go 37 56 66.07%
pkg/resource_handler_get_complete_ast.go 0 31 0.0%
pkg/resource_create_query.go 76 110 69.09%
pkg/resource_handler_get_ast_property.go 0 47 0.0%
pkg/resource_handler_apply_adhoc_filters.go 87 141 61.7%
src/datasource/helpers/index.ts 14 83 16.87%
Files with Coverage Reduction New Missed Lines %
src/datasource/datasource.ts 1 62.57%
Totals Coverage Status
Change from base Build 12278256209: -3.6%
Covered Lines: 2904
Relevant Lines: 3929
💛 - Coveralls

@coveralls
Copy link

coveralls commented Dec 17, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12413524231

Details

  • 118 of 214 (55.14%) changed or added relevant lines in 5 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-2.4%) to 73.546%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/datasource/wasm.ts 19 22 86.36%
pkg/eval_query.go 35 43 81.4%
src/datasource/datasource.ts 47 63 74.6%
src/datasource/helpers/index.ts 14 83 16.87%
Files with Coverage Reduction New Missed Lines %
src/datasource/datasource.ts 1 58.38%
Totals Coverage Status
Change from base Build 12408610410: -2.4%
Covered Lines: 2635
Relevant Lines: 3478
💛 - Coveralls

Slach
Slach requested changes Dec 17, 2024
View reviewed changes
pkg/datasource.go Outdated Show resolved Hide resolved
@Slach Slach changed the title remove all duplicated logic, move all macroses and query parsing functionality to BE remove all duplicated logic, move all macroses and query parsing functionality to golang, and compile golang parser to WASM Dec 18, 2024
lunaticusgreen and others added 16 commits December 18, 2024 14:39
@lunaticusgreen
Cleanup
2e789d2
@lunaticusgreen
fix typo
c39f533
@Slach
Merge branch 'master' of github.com:Altinity/clickhouse-grafana into v4
94f8135
@Slach
merged master to v4, update docker-compose to build wasm
1e0ee61 
Signed-off-by: Eugene Klimov <[email protected]>
@Slach
fix ci.yaml
e511078 
Signed-off-by: Eugene Klimov <[email protected]>
@Slach
fix ci.yaml, is-compatible.yml, release.yml
ce21fab 
Signed-off-by: Eugene Klimov <[email protected]>
@Slach
fuck where isStatement ;(
9614cc1 
Signed-off-by: Eugene Klimov <[email protected]>
@Slach
fix eval_query.go
bd18578 
Signed-off-by: Eugene Klimov <[email protected]>
@Slach
fix testflows tests
19e8304 
Signed-off-by: Eugene Klimov <[email protected]>
@lunaticusgreen
Add compression of wasm file
33292e6
@lunaticusgreen
Optimize build command
7530940
@Slach
merged master
93a1d2b 
Signed-off-by: Eugene Klimov <[email protected]>
@Slach
Merge remote-tracking branch 'origin/v4' into v4
1f0c38e
@lunaticusgreen
fix test command
e2f1c37
@lunaticusgreen
fix test command
169606f
@lunaticusgreen
fix test command
07b7f5c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Slach Slach Slach requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.

Rewrite parser to golang only
4 participants
@lunaticusgreen @Slach @antip00 @coveralls