Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified the ReadMe and Error message for custom remote option. Closed issue #1040 #1041

Merged
merged 3 commits into from
Nov 14, 2024

Conversation

mithunputhusseri
Copy link
Contributor

The ReadMe and Error message was not intuitive in custom option in remote storage.

Added more info on custom remote storage method
@mithunputhusseri mithunputhusseri changed the title Modified the ReadMe and Error message for custom remote option Modified the ReadMe and Error message for custom remote option. Closed issue #1040 Nov 6, 2024
ReadMe.md Outdated Show resolved Hide resolved
@Slach
Copy link
Collaborator

Slach commented Nov 6, 2024

thanks for contributing

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11702312697

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 253 unchanged lines in 11 files lost coverage.
  • Overall coverage decreased (-1.8%) to 65.922%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/backup/upload.go 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/backup/restore.go 1 67.67%
pkg/utils/utils.go 2 63.83%
cmd/clickhouse-backup/main.go 2 79.69%
pkg/storage/object_disk/object_disk.go 5 69.14%
pkg/config/config.go 8 73.37%
pkg/status/status.go 9 70.2%
pkg/storage/general.go 10 60.82%
pkg/backup/backuper.go 17 70.92%
pkg/server/server.go 18 58.67%
pkg/storage/s3.go 25 44.19%
Totals Coverage Status
Change from base Build 11662563984: -1.8%
Covered Lines: 9088
Relevant Lines: 13786

💛 - Coveralls

incorporated changes
@Slach Slach merged commit 0c3e0a2 into Altinity:master Nov 14, 2024
17 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants