Skip to content

Commit

Permalink
weird failures rbac / configs
Browse files Browse the repository at this point in the history
  • Loading branch information
Slach committed Aug 5, 2024
1 parent 7d898b3 commit 9c51529
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 4 deletions.
2 changes: 1 addition & 1 deletion ChangeLog.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# v2.5.24
BUG FIXES
- fix corner cases object disk parse endpoint for S3, to avoid wrong .amazonaws.amazonaws.com suffix
- fix corner cases object disk parse endpoint for S3, to avoid wrong `.amazonaws.amazonaws.com` suffix

# v2.5.23
BUG FIXES
Expand Down
8 changes: 5 additions & 3 deletions test/testflows/clickhouse_backup/tests/config_rbac.py
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,9 @@ def configs_backup_restore(self):
fail(f"{filename} not found, why you change file structure?")

with When(f"I create backup"):
backup.cmd(f"clickhouse-backup create --configs {table_name}")
r = backup.cmd(f"clickhouse-backup create --env=LOG_LEVEL=debug --configs {table_name}")
with Then("I expect clickhouse-backup to attempt create configs"):
assert "done createBackupConfigs" in r.output, error()

with When("I remove existing configuration to restore it later"):
for local_config_dir in ("configs/clickhouse", "configs/clickhouse1"):
Expand All @@ -52,9 +54,9 @@ def configs_backup_restore(self):
ch_node.cmd(f"truncate -s 0 /etc/clickhouse-server/{filename}")

with Then("I restore from the backup and restart"):
r = backup.cmd(f"clickhouse-backup restore --configs {table_name}", exitcode=None)
r = backup.cmd(f"clickhouse-backup restore --env=LOG_LEVEL=debug --configs {table_name}", exitcode=None)

with Then("I expect ch-backup to attempt restart ch-server"):
with Then("I expect clickhouse-backup to attempt restart clickhouse-server"):
assert "restart clickhouse-server" in r.output, error()

with And("I restart clickhouse, cause clickhouse-backup doesn't have access to systemd"):
Expand Down

0 comments on commit 9c51529

Please sign in to comment.