Makfile cleanup #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ormergi
force-pushed
the
makfile-cleanup
branch
2 times, most recently
from
ebf3d48 to
df6cc4e
Compare
AlonaKaplan
reviewed
Mar 11, 2024
Makefile
Outdated
| @@ -4,6 +4,8 @@ IMAGE_TAG ?= devel | |||
| # Image URL to use all building/pushing image targets | |||
| IMG ?= "${IMAGE_REGISTRY}/${IMAGE_NAME}:${IMAGE_TAG}" | |||
|
|
|||
| OCI_BIN ?= podman | |||
There was a problem hiding this comment.
OCI_BIN ?= $(shell if podman ps >/dev/null 2>&1; then echo podman; elif docker ps >/dev/null 2>&1; then echo docker; fi) can be used to fins the oci bin.
Make test generates 'cover.out' file Signed-off-by: Or Mergi <[email protected]>
No need for these targets at the moment. Signed-off-by: Or Mergi <[email protected]>
No need to provide multu arch images at this point. Signed-off-by: Or Mergi <[email protected]>
Introduce CONTAINER_TOOL variable to enable controlling the container runtime binary that will be used, following latest operator-sdk Makefile example. The builder container image tag is changed to full form to make it work for non docker container runtime. Signed-off-by: Or Mergi <[email protected]>
No need to envtests at the moment. Signed-off-by: Or Mergi <[email protected]>
In case Kind is not installed, cluster-up and cluster-down target fails. In addition, in case ./bin directory is not exist cluster-up fails. Set cluster-up and cluster-down target to depend on LOCALBIN target. Change cluster.sh to alway check if Kind binary exist. Signed-off-by: Or Mergi <[email protected]>
Signed-off-by: Or Mergi <[email protected]>
Introduce KUBECTL makefile variable to control kubectl binary path Signed-off-by: Or Mergi <[email protected]>
ormergi
force-pushed
the
makfile-cleanup
branch
from
df6cc4e to
b5ec41b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up Makefile a bit, it removes targets we currently dont need, such as building bundle images, catalog images, multi arch images.
All remaining targets are verified and work.