Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workflow v2 #569

Open
wants to merge 529 commits into
base: main
Choose a base branch
from
Open

Workflow v2 #569

wants to merge 529 commits into from
This pull request is big! We’re only showing the most recent 250 commits.

Commits on Jun 30, 2023

  1. reduce num tries to 3

    @aamster
    aamster committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    54fa563 View commit details
    Browse the repository at this point in the history

  2. add readme for testing

    @aamster
    aamster committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    7cba540 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2023

  1. fix docstring

    @aamster
    aamster committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    f39be32 View commit details
    Browse the repository at this point in the history

  2. set passed_or_qc_only to true for container

    @aamster
    aamster committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    a49e2ab View commit details
    Browse the repository at this point in the history

  3. improve formatting of readme

    @aamster
    aamster committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    574f9da View commit details
    Browse the repository at this point in the history

  4. add test for container has completed workflow step

    @aamster
    aamster committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    7f5b4e9 View commit details
    Browse the repository at this point in the history

  5. add additional doc for http_body

    @aamster
    aamster committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    a24b96a View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2023

  1. Merge pull request #591 from AllenInstitute/dev/workflow_debug_mode 

    Use short movie in debug mode and fix issues encountered
    @aamster
    aamster authored Jul 11, 2023
    Configuration menu
    Copy the full SHA
    3a855bd View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2023

  1. add dockerfile and values.yaml

    @aamster
    aamster committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    d4a2c56 View commit details
    Browse the repository at this point in the history

  2. fix Dockerfile 

    remove values.yaml
    @aamster
    aamster committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    0acd7aa View commit details
    Browse the repository at this point in the history

  3. try modify extras

    @aamster
    aamster committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    6a49153 View commit details
    Browse the repository at this point in the history

  4. try install libgl1

    @aamster
    aamster committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    24dba26 View commit details
    Browse the repository at this point in the history

  5. remove comma

    @aamster
    aamster committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    63a8ed8 View commit details
    Browse the repository at this point in the history

  6. add another install

    @aamster
    aamster committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    ed31d89 View commit details
    Browse the repository at this point in the history

  7. try using aws cli within docker image

    @aamster
    aamster committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    b6a27a9 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2023

  1. try pulling files directly in image

    @aamster
    aamster committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    050e4eb View commit details
    Browse the repository at this point in the history

  2. fix paths

    @aamster
    aamster committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    66b2f3b View commit details
    Browse the repository at this point in the history

  3. fix paths

    @aamster
    aamster committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    df9b4fb View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2023

  1. fully qualify host names

    @aamster
    aamster committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    a8bcd54 View commit details
    Browse the repository at this point in the history

  2. fully qualify host name

    @aamster
    aamster committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    eb4cb29 View commit details
    Browse the repository at this point in the history

  3. add argument to initialize app db

    @aamster
    aamster committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    4adc1db View commit details
    Browse the repository at this point in the history

  4. add backslash

    @aamster
    aamster committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    f3c656b View commit details
    Browse the repository at this point in the history

  5. exit if required args not passed

    @aamster
    aamster committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    decfeb3 View commit details
    Browse the repository at this point in the history

  6. fix

    @aamster
    aamster committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    ffbf29b View commit details
    Browse the repository at this point in the history

  7. fix

    @aamster
    aamster committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    1bf5b64 View commit details
    Browse the repository at this point in the history

  8. fix

    @aamster
    aamster committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    27fd311 View commit details
    Browse the repository at this point in the history

  9. fix

    @aamster
    aamster committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    586e13f View commit details
    Browse the repository at this point in the history

  10. fix

    @aamster
    aamster committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    9ef3200 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2023

  1. remove logic to get custom webserver ip address (doesnt work in helm … 

    …chart)

set webserver ip address (needs to be set in helm chart)
    @aamster
    aamster committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    bfdc5a9 View commit details
    Browse the repository at this point in the history

  2. parameterize branch name

    @aamster
    aamster committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    4c6aaef View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2023

  1. add airflow-amazon provider

    @aamster
    aamster committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    fbfc1da View commit details
    Browse the repository at this point in the history

  2. change name to host_name

    @aamster
    aamster committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    5db55aa View commit details
    Browse the repository at this point in the history

  3. use version of app_config so we don't have to rebuild without caching

    @aamster
    aamster committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    e1aa69a View commit details
    Browse the repository at this point in the history

  4. set default value for app_config_s3_version_id

    @aamster
    aamster committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    c3294ae View commit details
    Browse the repository at this point in the history

  5. revert previous 2 commits

    @aamster
    aamster committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    5c87eca View commit details
    Browse the repository at this point in the history

  6. dont make dirs (doesnt have write access, let module running in slurm… 

    … do it)
    @aamster
    aamster committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    0bb6f2a View commit details
    Browse the repository at this point in the history

  7. write logs to module output, rather than airflow task output

    @aamster
    aamster committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    2b2fb8a View commit details
    Browse the repository at this point in the history

  8. remove makedirs in another place

    @aamster
    aamster committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    9024170 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2023

  1. revert adding amazon provider

    @aamster
    aamster committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    8e7cf85 View commit details
    Browse the repository at this point in the history

  2. remove unused args

    @aamster
    aamster committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    344e365 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'prod_deploy' of https://github.com/AllenInstitute/ophys… 

    …_etl_pipelines into prod_deploy
    @aamster
    aamster committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    5905197 View commit details
    Browse the repository at this point in the history

  4. Revert "dont make dirs (doesnt have write access, let module running … 

    …in slurm do it)"

This reverts commit 0bb6f2a.
    @aamster
    aamster committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    fe26d76 View commit details
    Browse the repository at this point in the history

  5. Revert "write logs to module output, rather than airflow task output" 

    This reverts commit 2b2fb8a.
    @aamster
    aamster committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    b7b8eeb View commit details
    Browse the repository at this point in the history

  6. Revert "remove makedirs in another place" 

    This reverts commit 9024170.
    @aamster
    aamster committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    7a60069 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2023

  1. add psycopg2

    @aamster
    aamster committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    463295c View commit details
    Browse the repository at this point in the history

  2. fix dep name

    @aamster
    aamster committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    71e677c View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2023

  1. revert add dep

    @aamster
    aamster committed Jul 29, 2023
    Configuration menu
    Copy the full SHA
    9a659dc View commit details
    Browse the repository at this point in the history

  2. add back in dep

    @aamster
    aamster committed Jul 29, 2023
    Configuration menu
    Copy the full SHA
    9ecbbbc View commit details
    Browse the repository at this point in the history

  3. Revert "add back in dep" 

    This reverts commit 9ecbbbc.
    @aamster
    aamster committed Jul 29, 2023
    Configuration menu
    Copy the full SHA
    635a01e View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2023

  1. set start_date to yesterday to avoid race condition

    @aamster
    aamster committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    3d42660 View commit details
    Browse the repository at this point in the history

  2. add additional steps to readme

    @aamster
    aamster committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    ed3a12f View commit details
    Browse the repository at this point in the history

  3. add host user to docker image 

    fix various other issues with dockerfile
    @aamster
    aamster committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    27ebf5e View commit details
    Browse the repository at this point in the history

  4. move slurm settings into app config

    @aamster
    aamster committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    2c61a15 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2023

  1. use dags internally downloaded in dockerfile rather than local to avo… 

    …id issues
    @aamster
    aamster committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    3c524ea View commit details
    Browse the repository at this point in the history

  2. add details in readme

    @aamster
    aamster committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    1f1e07e View commit details
    Browse the repository at this point in the history

  3. remove unused import

    @aamster
    aamster committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    35e6aa2 View commit details
    Browse the repository at this point in the history

  4. fix issue in which wrong task is selected to be retried on failure

    @aamster
    aamster committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    3288e59 View commit details
    Browse the repository at this point in the history

  5. no longer copy di model into docker image

    @aamster
    aamster committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    5abda08 View commit details
    Browse the repository at this point in the history

  6. add debugging steps

    @aamster
    aamster committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    dfb83f8 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2023

  1. add more logging

    @aamster
    aamster committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    01cfe3b View commit details
    Browse the repository at this point in the history

  2. set to <=

    @aamster
    aamster committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    a430086 View commit details
    Browse the repository at this point in the history

  3. add comment

    @aamster
    aamster committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    01e0466 View commit details
    Browse the repository at this point in the history

  4. fix issue with passing --nv and gpus: 0

    @aamster
    aamster committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    cccf728 View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2023

  1. remove app db creation from dockerfile

    @aamster
    aamster committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    6a8b856 View commit details
    Browse the repository at this point in the history

  2. add object type and id to run id in order to search for it in UI

    @aamster
    aamster committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    ab74391 View commit details
    Browse the repository at this point in the history

  3. fix typo

    @aamster
    aamster committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    c951403 View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2023

  1. fix retry logic. The value in config is number of retries, not number… 

    … of tries, and task_instance.try_number is next try number
    @aamster
    aamster committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    8053270 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2023

  1. parameterize partition

    @aamster
    aamster committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    910d52f View commit details
    Browse the repository at this point in the history

  2. set start_date in the past according to https://airflow.apache.org/do… 

    …cs/apache-airflow/stable/faq.html#what-s-the-deal-with-start-date
    @aamster
    aamster committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    67f5c22 View commit details
    Browse the repository at this point in the history

  3. remove unused imports

    @aamster
    aamster committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    c2cd5f0 View commit details
    Browse the repository at this point in the history

  4. create new object rather than set values (immutable)

    @aamster
    aamster committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    d49bf21 View commit details
    Browse the repository at this point in the history

  5. bugfix: use max_active_runs=1 instead of more complicated logic

    @aamster
    aamster committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    bdade83 View commit details
    Browse the repository at this point in the history

  6. add logging

    @aamster
    aamster committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    3153d33 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2023

  1. bugfix: logical_date is not the time when the trigger was run but the… 

    … time when the trigger was scheduled to wait to run.

Use start_date instead to check for all experiments finished between the time the last trigger started to run and now
    @aamster
    aamster committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    4b81aaf View commit details
    Browse the repository at this point in the history

  2. Merge pull request #594 from AllenInstitute/prod_deploy 

    PSB-169 Prod deploy
    @aamster
    aamster authored Aug 8, 2023
    Configuration menu
    Copy the full SHA
    fbaac43 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2023

  1. make dockerfile compatible with either dev or prod

    @aamster
    aamster committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    7b10904 View commit details
    Browse the repository at this point in the history

  2. add docker-compose.yaml

    @aamster
    aamster committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    2a93744 View commit details
    Browse the repository at this point in the history

  3. update readme

    @aamster
    aamster committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    ffce621 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2023

  1. postgres stored separately for each container 

    Give a unique image name to separate the images
Use local code rather than pulling from github
    @aamster
    aamster committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    9ee1ba1 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2023

  1. remove AIRFLOW_PROJ_DIR 

    give descriptive names to running containers
update readme
    @aamster
    aamster committed Aug 12, 2023
    Configuration menu
    Copy the full SHA
    89e46b1 View commit details
    Browse the repository at this point in the history

  2. add note

    @aamster
    aamster committed Aug 12, 2023
    Configuration menu
    Copy the full SHA
    c913b9a View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2023

  1. Use argschema validation to load inputs on PipelineModules

    @mikejhuang
    mikejhuang committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    9861d05 View commit details
    Browse the repository at this point in the history

  2. pin tensorflow version

    @aamster
    aamster committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    f122367 View commit details
    Browse the repository at this point in the history

  3. "conda init" not working. 

    Instead of using conda, install python version directly onto machine and use it.
    @aamster
    aamster committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    dc47bca View commit details
    Browse the repository at this point in the history

  4. fix missing comma

    @aamster
    aamster committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    5992101 View commit details
    Browse the repository at this point in the history

  5. explicitly pass coverage path

    @aamster
    aamster committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    178427d View commit details
    Browse the repository at this point in the history

  6. explicitly pass coverage exe path

    @aamster
    aamster committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    eae9d11 View commit details
    Browse the repository at this point in the history

  7. try different default value

    @aamster
    aamster committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    d2fae66 View commit details
    Browse the repository at this point in the history

  8. try again

    @aamster
    aamster committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    6041f22 View commit details
    Browse the repository at this point in the history

  9. try again

    @aamster
    aamster committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    9535ce0 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2023

  1. Update PipelineModule to enforce module_argschema and validate inputs

    @mikejhuang
    mikejhuang committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    b23830a View commit details
    Browse the repository at this point in the history

  2. update all PipelineModule classes to use validation setup, rename cla… 

    …sses to end with Module along with associated tests
    @mikejhuang
    mikejhuang committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    c7cc0d0 View commit details
    Browse the repository at this point in the history

  3. use lower version tensorflow

    @aamster
    aamster committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    ed8c1c4 View commit details
    Browse the repository at this point in the history

  4. add missing property

    @aamster
    aamster committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    4e5101c View commit details
    Browse the repository at this point in the history

  5. update TestPipelineModule with validation modifications

    @mikejhuang
    mikejhuang committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    1bfe54a View commit details
    Browse the repository at this point in the history

  6. download img to tmpdir, disable caching

    @aamster
    aamster committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    e81d988 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2023

  1. rename test_<pipelinemodule> to test_<pipelinemodule>_module to preve… 

    …nt name conflicts with module tests
    @mikejhuang
    mikejhuang committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    4a1baf0 View commit details
    Browse the repository at this point in the history

  2. change typing of schema to DefaultSchema instead of Argschema

    @mikejhuang
    mikejhuang committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    7250736 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2023

  1. init pipelinemodule after class instance variables on eventdetection

    @mikejhuang
    mikejhuang committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    4653308 View commit details
    Browse the repository at this point in the history

  2. add tempdir and dummy file in TestSlurm for MotionCorrectionModule va… 

    …lidation
    @mikejhuang
    mikejhuang committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    0d4cff0 View commit details
    Browse the repository at this point in the history

  3. adds timestamp to log 

    adds logging
simplifies move stats calc
    @aamster
    aamster committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    d841eaa View commit details
    Browse the repository at this point in the history

  4. mock PipelineModule.output_path and OphysSession.output_dir to a temp… 

    …file.TemporaryDirectory()
    @mikejhuang
    mikejhuang committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    07b85a4 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2023

  1. use tempfile for slurm test output_paths

    @mikejhuang
    mikejhuang committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    eed128b View commit details
    Browse the repository at this point in the history

  2. temporarily update di branch

    @aamster
    aamster committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    9be9433 View commit details
    Browse the repository at this point in the history

  3. set stream to stdout

    @aamster
    aamster committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    ae4528c View commit details
    Browse the repository at this point in the history

  4. mock input_args_path on test_pipeline_module with tempdir

    @mikejhuang
    mikejhuang committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    dd63152 View commit details
    Browse the repository at this point in the history

  5. remove unused files

    @mikejhuang
    mikejhuang committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    3fb3f4c View commit details
    Browse the repository at this point in the history

  6. rename module_argschema to module_schema

    @mikejhuang
    mikejhuang committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    14663ff View commit details
    Browse the repository at this point in the history

  7. increase finetuning timelimit

    @aamster
    aamster committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    6932805 View commit details
    Browse the repository at this point in the history

  8. removed unused imports 

    remove unused imports 2
    @mikejhuang
    mikejhuang committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    168b6cf View commit details
    Browse the repository at this point in the history

  9. lint 

    lint
    @mikejhuang
    mikejhuang committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    2061896 View commit details
    Browse the repository at this point in the history

  10. change inputs to a property

    @mikejhuang
    mikejhuang committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    c879b28 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2023

  1. update readme

    @aamster
    aamster committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    bb10e1b View commit details
    Browse the repository at this point in the history

  2. add UID to container name

    @aamster
    aamster committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    61416a1 View commit details
    Browse the repository at this point in the history

  3. make tagname unique

    @aamster
    aamster committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    03d2272 View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2023

  1. switch di branch

    @aamster
    aamster committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    f6b2717 View commit details
    Browse the repository at this point in the history

  2. it is possible for a single job id to map to multiple jobs in the cas… 

    …e of NODE_FAIL.

Take the last (most recent job) from the list
    @aamster
    aamster committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    39066a8 View commit details
    Browse the repository at this point in the history

  3. remove dir empty check (it's possible to be empty)

    @aamster
    aamster committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    f76215b View commit details
    Browse the repository at this point in the history

  4. remove unused args

    @aamster
    aamster committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    8a088df View commit details
    Browse the repository at this point in the history

  5. update test

    @aamster
    aamster committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    ba98ba0 View commit details
    Browse the repository at this point in the history

  6. update test

    @aamster
    aamster committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    ae87845 View commit details
    Browse the repository at this point in the history

  7. Check that all experiments have completed segmentation in order to ru… 

    …n decrosstalk
    @aamster
    aamster committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    adc734d View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2023

  1. manually kill process

    @aamster
    aamster committed Aug 27, 2023
    Configuration menu
    Copy the full SHA
    408f046 View commit details
    Browse the repository at this point in the history

  2. disable kill process when running in pytest

    @aamster
    aamster committed Aug 27, 2023
    Configuration menu
    Copy the full SHA
    5eb02f8 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2023

  1. Add details about app_config.yml

    @aamster
    aamster committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    4762e53 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #595 from AllenInstitute/docker_dev_env 

    PSB-176 Docker dev env
    @aamster
    aamster authored Aug 28, 2023
    Configuration menu
    Copy the full SHA
    f6cd784 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #598 from AllenInstitute/dev_unique_tagname 

    PSB-132 Tag image with unique tag
    @aamster
    aamster authored Aug 28, 2023
    Configuration menu
    Copy the full SHA
    c22f93b View commit details
    Browse the repository at this point in the history

  4. try clear_session()

    @aamster
    aamster committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    72baa6b View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2023

  1. remove module_args and only use inputs

    @mikejhuang
    mikejhuang committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    09cf0d2 View commit details
    Browse the repository at this point in the history

  2. try disabling multiprocessing

    @aamster
    aamster committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    7ba02b0 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'workflow_v2' of https://github.com/AllenInstitute/ophys… 

    …_etl_pipelines into dev_fix_tf_version
    @aamster
    aamster committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    4b4c46a View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2023

  1. update repo for di

    @aamster
    aamster committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    8e05594 View commit details
    Browse the repository at this point in the history

  2. update nb_workers

    @aamster
    aamster committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    8ce37b3 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2023

  1. trace_processing pipeline modules unit tests and fixes

    @mikejhuang
    mikejhuang committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    ed5f2f0 View commit details
    Browse the repository at this point in the history

  2. reorder pipeline module super init to after module kwargs

    @mikejhuang
    mikejhuang committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    5c27f9d View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2023

  1. refactor tests to share fixtures/db from conftest

    @mikejhuang
    mikejhuang committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    111634d View commit details
    Browse the repository at this point in the history

  2. fix bug

    @mikejhuang
    mikejhuang committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    1006ad9 View commit details
    Browse the repository at this point in the history

  3. additional tests

    @mikejhuang
    mikejhuang committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    2981c7c View commit details
    Browse the repository at this point in the history

  4. refactor conftest to deal with fixtures in setup

    @mikejhuang
    mikejhuang committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    2bea106 View commit details
    Browse the repository at this point in the history

  5. increase trigger interval to 60 minutes

    @mikejhuang
    mikejhuang committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    97ba148 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2023

  1. additional test fixes

    @mikejhuang
    mikejhuang committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    c075915 View commit details
    Browse the repository at this point in the history

  2. change di branch to main branch

    @aamster
    aamster authored Sep 6, 2023
    Configuration menu
    Copy the full SHA
    89896fc View commit details
    Browse the repository at this point in the history

  3. Merge pull request #600 from AllenInstitute/dev_fix_tf_version 

    PSB-168 Various fixes to pipeline
    @aamster
    aamster authored Sep 6, 2023
    Configuration menu
    Copy the full SHA
    7546bfc View commit details
    Browse the repository at this point in the history

  4. fix or remove roi_classification tests

    @mikejhuang
    mikejhuang committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    f055438 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2023

  1. remove unused imports

    @mikejhuang
    mikejhuang committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    53a1fc9 View commit details
    Browse the repository at this point in the history

  2. lint

    @mikejhuang
    mikejhuang committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    8ef7539 View commit details
    Browse the repository at this point in the history

  3. remove commented code

    @mikejhuang
    mikejhuang committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    a8905fb View commit details
    Browse the repository at this point in the history

  4. circleci test config for deepinterpolation pipelinemodule tests

    @mikejhuang
    mikejhuang committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    985b0a9 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'workflow_v2' into psb-133/validate_inputs_with_argschema

    @mikejhuang
    mikejhuang authored Sep 7, 2023
    Configuration menu
    Copy the full SHA
    6998f48 View commit details
    Browse the repository at this point in the history

  6. lint

    @mikejhuang
    mikejhuang committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    808f155 View commit details
    Browse the repository at this point in the history

  7. increase denoising inference timeout

    @aamster
    aamster committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    a9b6e18 View commit details
    Browse the repository at this point in the history

  8. set static start_date

    @aamster
    aamster committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    875753e View commit details
    Browse the repository at this point in the history

  9. Merge branch 'workflow_v2' of https://github.com/AllenInstitute/ophys… 

    …_etl_pipelines into workflow_v2
    @aamster
    aamster committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    09a7ff8 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2023

  1. pytest mark test build config 

    pytest mark test build config2

pytest mark test build config3
    @mikejhuang
    mikejhuang committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    7919b49 View commit details
    Browse the repository at this point in the history

  2. parameterize nonrigid

    @aamster
    aamster committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    0e135a2 View commit details
    Browse the repository at this point in the history

  3. skip denoising imports if not found

    @mikejhuang
    mikejhuang committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    794e91a View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2023

  1. add denoising test class to try 

    lint
    @mikejhuang
    mikejhuang committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    cb84a7d View commit details
    Browse the repository at this point in the history

  2. Merge pull request #603 from AllenInstitute/add_nonrigid 

    PSB-197 parameterize nonrigid
    @aamster
    aamster authored Sep 11, 2023
    Configuration menu
    Copy the full SHA
    8cdea9c View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2023

  1. address test comments

    @mikejhuang
    mikejhuang committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    09487f7 View commit details
    Browse the repository at this point in the history

  2. lint

    @mikejhuang
    mikejhuang committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    b050588 View commit details
    Browse the repository at this point in the history

  3. revert TrainScehma

    @mikejhuang
    mikejhuang committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    05e078e View commit details
    Browse the repository at this point in the history

  4. should be pytest.mark.skip

    @mikejhuang
    mikejhuang committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    880dab0 View commit details
    Browse the repository at this point in the history

  5. change train schema

    @mikejhuang
    mikejhuang committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    0abe605 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2023

  1. Allows to override some slurm settings while retaining defaults defin… 

    …ed in PipelineStep subclass
    @aamster
    aamster committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    1e1233b View commit details
    Browse the repository at this point in the history

  2. revert accidental change

    @aamster
    aamster committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    a47e691 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #604 from AllenInstitute/override_some_app_config 

    Override some app config
    @aamster
    aamster authored Sep 13, 2023
    Configuration menu
    Copy the full SHA
    6745ea5 View commit details
    Browse the repository at this point in the history

  4. try fix issue with import libstdc++.so.6

    @aamster
    aamster committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    56bc72c View commit details
    Browse the repository at this point in the history

  5. Merge branch 'workflow_v2' of https://github.com/AllenInstitute/ophys… 

    …_etl_pipelines into workflow_v2
    @aamster
    aamster committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    7acb478 View commit details
    Browse the repository at this point in the history

  6. export ld_library_path

    @aamster
    aamster committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    9c81805 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2023

  1. remove database setup in trace_processing tests

    @mikejhuang
    mikejhuang committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    1156423 View commit details
    Browse the repository at this point in the history

  2. remove unused import

    @mikejhuang
    mikejhuang committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    3a9e6db View commit details
    Browse the repository at this point in the history

  3. remove unneeded db setup in roi_classification tests

    @mikejhuang
    mikejhuang committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    bda948d View commit details
    Browse the repository at this point in the history

  4. Merge branch 'workflow_v2' into psb-133/validate_inputs_with_argschema

    @mikejhuang
    mikejhuang committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    71b8f1b View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2023

  1. remove unnecessary db setup from denoising and associated class from … 

    …conftest
    @mikejhuang
    mikejhuang committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    355b0fc View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2023

  1. remove uneeded db setup from roi_classifier tests

    @mikejhuang
    mikejhuang committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    7634e46 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2023

  1. add test_input for segmentation_postprocess, fix module input

    @mikejhuang
    mikejhuang committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    6f92ae2 View commit details
    Browse the repository at this point in the history

  2. add constructor to motion correction pipelinemodule

    @mikejhuang
    mikejhuang committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    a388f5b View commit details
    Browse the repository at this point in the history

  3. add test_input for motion correction

    @mikejhuang
    mikejhuang committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    c6c1308 View commit details
    Browse the repository at this point in the history

  4. remove module from test filenames and add init file in dir with non u… 

    …nique names
    @mikejhuang
    mikejhuang committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    82ef0cf View commit details
    Browse the repository at this point in the history

  5. lint

    @mikejhuang
    mikejhuang committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    446cd86 View commit details
    Browse the repository at this point in the history

  6. Merge pull request #601 from AllenInstitute/psb-187/increase_ophys_tr… 

    …igger_scheduler_interval

PSB-188 increase trigger interval to 60 minutes
    @mikejhuang
    mikejhuang authored Sep 21, 2023
    Configuration menu
    Copy the full SHA
    0635a3f View commit details
    Browse the repository at this point in the history

  7. remove erroneously added test cache dir

    @mikejhuang
    mikejhuang committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    5746580 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2023

  1. bugfix: get motion border for experiment

    @aamster
    aamster committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    e612ed3 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2023

  1. remove unnecessary constructor

    @mikejhuang
    mikejhuang committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    0acc3dd View commit details
    Browse the repository at this point in the history

  2. Merge pull request #596 from AllenInstitute/psb-133/validate_inputs_w… 

    …ith_argschema

Validate inputs with argschema
    @mikejhuang
    mikejhuang authored Sep 23, 2023
    Configuration menu
    Copy the full SHA
    eef5049 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2023

  1. disable normalize_cache, enable gpu

    @mikejhuang
    mikejhuang committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    2605b8c View commit details
    Browse the repository at this point in the history

  2. Merge pull request #609 from AllenInstitute/psb-218/disable-inference… 

    …-normalize_cache

disable normalize_cache, enable gpu
    @mikejhuang
    mikejhuang authored Sep 25, 2023
    Configuration menu
    Copy the full SHA
    9b0d812 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2023

  1. Merge pull request #608 from AllenInstitute/fix_motion_border 

    PSB-223 bugfix: get motion border for experiment
    @aamster
    aamster authored Sep 26, 2023
    Configuration menu
    Copy the full SHA
    8a6883b View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2023

  1. make wait_for_dag_to_finish more generic 

    Add tests for airflow components
install deepinterpolation into Dockerfile, since needed for test
    @aamster
    aamster committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    085428a View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2023

  1. try unpin argschema

    @aamster
    aamster committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    8feec8e View commit details
    Browse the repository at this point in the history

  2. pin argschema to higher version

    @aamster
    aamster committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    8a506a7 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'workflow_v2' of https://github.com/AllenInstitute/ophys… 

    …_etl_pipelines into dev/psb-210
    @aamster
    aamster committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    b0b53e6 View commit details
    Browse the repository at this point in the history

  4. try set AIRFLOW_HOME

    @aamster
    aamster committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    8384adf View commit details
    Browse the repository at this point in the history

  5. set AIRFLOW_HOME to tmpdir

    @aamster
    aamster committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    342331b View commit details
    Browse the repository at this point in the history

  6. move wait_for_dag_to_finish import later

    @aamster
    aamster committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    bb17a47 View commit details
    Browse the repository at this point in the history

  7. try unpin argschema

    @aamster
    aamster committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    4d67ce5 View commit details
    Browse the repository at this point in the history

  8. Merge pull request #614 from AllenInstitute/dev/psb-210 

    PSB-210 Block ophys_processing dag from completing until other dags complete
    @aamster
    aamster authored Sep 28, 2023
    Configuration menu
    Copy the full SHA
    40c2ceb View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2023

  1. sets sensitive configs from airflow Variable 

    add staging app_config
    @aamster
    aamster committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    0c38f39 View commit details
    Browse the repository at this point in the history

  2. set airflow_home in conftest.py

    @aamster
    aamster committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    ef3cdd9 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2023

  1. add empty_roi_mask and empty_neuropil_mask exclusion labels to OphysROI

    @mikejhuang
    mikejhuang committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    29eb961 View commit details
    Browse the repository at this point in the history

  2. Add deploy script

    @aamster
    aamster committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    8b82fd5 View commit details
    Browse the repository at this point in the history

  3. lint

    @aamster
    aamster committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    a0bf0b5 View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2023

  1. Merge pull request #615 from AllenInstitute/app_config_secrets 

    PSB-234 Fetch secret variables and add app_config.yml
    @aamster
    aamster authored Oct 6, 2023
    Configuration menu
    Copy the full SHA
    e81d0ba View commit details
    Browse the repository at this point in the history

  2. Merge pull request #616 from AllenInstitute/deploy_script 

    PSB-237 Add deploy script
    @aamster
    aamster authored Oct 6, 2023
    Configuration menu
    Copy the full SHA
    69d5f00 View commit details
    Browse the repository at this point in the history

  3. bugfix: superclass constructor needs to be called before _write_model… 

    …_inputs_to_disk
    @aamster
    aamster committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    7724832 View commit details
    Browse the repository at this point in the history

  4. remove unused imports

    @aamster
    aamster committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    66bad5a View commit details
    Browse the repository at this point in the history

  5. add save_exclusion_labels_to_db to trace_extraction pipeline mod

    @mikejhuang
    mikejhuang committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    998b3cf View commit details
    Browse the repository at this point in the history

  6. refactor segmentation test with fixtures

    @mikejhuang
    mikejhuang committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    6247c90 View commit details
    Browse the repository at this point in the history

  7. add test for save_db_to_workflow in trace_extraction pipeline mod

    @mikejhuang
    mikejhuang committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    5a92555 View commit details
    Browse the repository at this point in the history

  8. remove unused imports

    @mikejhuang
    mikejhuang committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    2d607de View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2023

  1. lint

    @mikejhuang
    mikejhuang committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    c8366dc View commit details
    Browse the repository at this point in the history

  2. add save_exclusion_labels_to_db to task_group additional_inserts

    @mikejhuang
    mikejhuang committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    4817262 View commit details
    Browse the repository at this point in the history

  3. lint

    @mikejhuang
    mikejhuang committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    d1696fd View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2023

  1. Increase timelimit on dff

    @aamster
    aamster authored Oct 9, 2023
    Configuration menu
    Copy the full SHA
    46840ff View commit details
    Browse the repository at this point in the history

  2. Increase mem on decrosstalk

    @aamster
    aamster authored Oct 9, 2023
    Configuration menu
    Copy the full SHA
    51041b2 View commit details
    Browse the repository at this point in the history

  3. try also install amazon providers package

    @aamster
    aamster committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    7b18952 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'workflow_v2' of https://github.com/AllenInstitute/ophys… 

    …_etl_pipelines into workflow_v2
    @aamster
    aamster committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    2c4c3de View commit details
    Browse the repository at this point in the history

  5. use python 3.8 version

    @aamster
    aamster committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    2c73e85 View commit details
    Browse the repository at this point in the history

  6. get current commit before deploying

    @aamster
    aamster committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    f06d907 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2023

  1. Merge pull request #617 from AllenInstitute/ticket/psb-239 

    PSB-239 bugfix: Superclass constructor not called before self.output_path
    @aamster
    aamster authored Oct 10, 2023
    Configuration menu
    Copy the full SHA
    341e64c View commit details
    Browse the repository at this point in the history

  2. PSB-244 Increase timeout on trace extraction

    @aamster
    aamster authored Oct 10, 2023
    Configuration menu
    Copy the full SHA
    7ffb78c View commit details
    Browse the repository at this point in the history

  3. PSB-247 Increase mem limit on corr proj

    @aamster
    aamster authored Oct 10, 2023
    Configuration menu
    Copy the full SHA
    8ed7f6c View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2023

  1. remove empty_roi_mask flag

    @mikejhuang
    mikejhuang committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    cc1dd10 View commit details
    Browse the repository at this point in the history

  2. extra logic in PostProcessROIs to ensure segmented roi's aren't empty 

    remove logger statement
    @mikejhuang
    mikejhuang committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    7a1d65a View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2023

  1. various fixes

    @mikejhuang
    mikejhuang committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    87a6308 View commit details
    Browse the repository at this point in the history

  2. fix tests 

    fix tests 2

fix tests3
    @mikejhuang
    mikejhuang committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    146e262 View commit details
    Browse the repository at this point in the history

  3. change typing

    @mikejhuang
    mikejhuang committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    2f8c89c View commit details
    Browse the repository at this point in the history

  4. Merge pull request #618 from AllenInstitute/psb-242/add_trace_extract… 

    …ion_roi_exclusion_labels

PSB-242: add trace extraction roi exclusion labels
    @mikejhuang
    mikejhuang authored Oct 12, 2023
    Configuration menu
    Copy the full SHA
    1dcbf0b View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2023

  1. remove duplicate motion_border_check_logic

    @mikejhuang
    mikejhuang committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    dd1666a View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2023

  1. fix inside_motion_border logic

    @mikejhuang
    mikejhuang committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    b1a0aa6 View commit details
    Browse the repository at this point in the history

  2. fix is_inside_motion_border function call

    @mikejhuang
    mikejhuang committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    4ae2547 View commit details
    Browse the repository at this point in the history

  3. fix save_metadata_to_db in trace_extraction

    @mikejhuang
    mikejhuang committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    0099a70 View commit details
    Browse the repository at this point in the history

  4. lint

    @mikejhuang
    mikejhuang committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    c51d8a5 View commit details
    Browse the repository at this point in the history

  5. Fix arguments to CreateTrainTestSplit 

    remove redundant setup_app_config calls
set output_dir in conftest
    @aamster
    aamster committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    ec82bca View commit details
    Browse the repository at this point in the history

  6. temporarily update branch

    @aamster
    aamster committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    421f957 View commit details
    Browse the repository at this point in the history

  7. noqa

    @aamster
    aamster committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    161e898 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2023

  1. update output_dir

    @aamster
    aamster committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    28ead56 View commit details
    Browse the repository at this point in the history

  2. add test

    @aamster
    aamster committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    10cf74e View commit details
    Browse the repository at this point in the history

  3. Update to pull main branch

    @aamster
    aamster authored Oct 18, 2023
    Configuration menu
    Copy the full SHA
    7fdf05f View commit details
    Browse the repository at this point in the history

  4. Merge pull request #623 from AllenInstitute/ticket/psb-192 

    PSB-192 passes `exp_roi_meta_map` to `CreateDatasetInputSchema`
    @aamster
    aamster authored Oct 18, 2023
    Configuration menu
    Copy the full SHA
    a651590 View commit details
    Browse the repository at this point in the history

  5. add edge cases for testing is_inside_motion_border

    @mikejhuang
    mikejhuang committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    e303a38 View commit details
    Browse the repository at this point in the history

  6. inside_motion_border reverted back to mean not overlapping motion border

    @mikejhuang
    mikejhuang committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    f163272 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'workflow_v2' into psb-238/remove_redundant_motion_borde… 

    …r_validation
    @mikejhuang
    mikejhuang committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    39cff88 View commit details
    Browse the repository at this point in the history

  8. lint

    @mikejhuang
    mikejhuang committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    8235aa7 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2023

  1. docfix

    @mikejhuang
    mikejhuang committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    ce885f7 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #622 from AllenInstitute/psb-238/remove_redundant_… 

    …motion_border_validation

Psb 238/remove redundant motion border validation
    @mikejhuang
    mikejhuang authored Oct 20, 2023
    Configuration menu
    Copy the full SHA
    dc54ecd View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2023

  1. Merge branch 'main' into workflow_v2

    @morriscb
    morriscb committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    adf9b31 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2023

  1. fill rmse value with nan if traces contain nan 

    fix
    @mikejhuang
    mikejhuang committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    b2f1dc5 View commit details
    Browse the repository at this point in the history

  2. fix

    @mikejhuang
    mikejhuang committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    189d06c View commit details
    Browse the repository at this point in the history

  3. Merge pull request #611 from AllenInstitute/psb-222/neuropil_correcti… 

    …on_nan_bugfix

neuropil_correction nan bugfix
    @mikejhuang
    mikejhuang authored Nov 7, 2023
    Configuration menu
    Copy the full SHA
    dbeca05 View commit details
    Browse the repository at this point in the history