Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support spaces in the key of an S3 URI when validating. #22

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

sheriferson
Copy link
Contributor

Copy link

codecov bot commented Jan 3, 2025

Codecov Report

Attention: Patch coverage is 71.42857% with 4 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@1fa05d2). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/aibs_informatics_core/models/aws/s3.py 71.42% 2 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #22   +/-   ##
=======================================
  Coverage        ?   96.45%           
=======================================
  Files           ?       54           
  Lines           ?     3554           
  Branches        ?      403           
=======================================
  Hits            ?     3428           
  Misses          ?       71           
  Partials        ?       55           
Files with missing lines Coverage Δ
src/aibs_informatics_core/models/aws/s3.py 95.53% <71.42%> (ø)

@sheriferson sheriferson marked this pull request as ready for review January 3, 2025 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant