Make get_or_set_index immune to memory address reuse #5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a mutex instance gets used, deleted and then recreated in the same thread - especially on the stack, the new instance might get the same memory address as the old instance. Because of this, a lookup in
thread_local_index_hashmap
can't be based on the instance address (this
), but rather on the (heap allocated, shared)shared_locks_array
instance address, because that one will not be reused even after the mutex instance is deleted since allunregister_t
structs still hold astd::shared_ptr
to it until they get erased fromthread_local_index_hashmap
.I only ran the benchmark from
object_threadsafe/benchmark
, hope that's fine, I would expect the fix to have no impact on performance:Before the change:
After the change: