Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update metainfo, update link in appimage build #712

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Drsheppard01
Copy link

No description provided.

@gz83 gz83 requested a review from Alex313031 June 12, 2024 00:00
Copy link
Owner

@Alex313031 Alex313031 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Drsheppard01

Nice. Gonna approve this, although the 2 .xml files need some minor editing, but I will do that later.

Is it OK to have a org ID of rocks.thorium.Thorium?
I don't have much experience with flatpaks or snap, but in everything that I have seen, as well as things like NSIS and electron-builder (for making Electron apps), always uses com, org, or io for the initial string.

@gz83 @midzer Might try a stab at getting Flatpak to work again lol now that this guy did all this

@Drsheppard01
Copy link
Author

Is it OK to have a org ID of rocks.thorium.Thorium?

Yep, you can see this https://flathub.org/apps/garden.jamie.Morphosis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants