Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

right-click menu placing #1447

Merged
merged 7 commits into from
Mar 11, 2024
Merged

right-click menu placing #1447

merged 7 commits into from
Mar 11, 2024

Conversation

ethical-haquer
Copy link
Contributor

@ethical-haquer ethical-haquer commented Mar 10, 2024

Added 10 pixels offset to right-click menus
Fixes #1429

@ethical-haquer ethical-haquer changed the title right-click menu placing porcupine#1429 right-click menu placing Mar 10, 2024
Copy link
Owner

@Akuli Akuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! A couple things:

  • You missed one of the four menus. Run git grep tk_popup to find all places where menus are shown.
  • These also need y offset.

@Akuli
Copy link
Owner

Akuli commented Mar 10, 2024

The y offset is needed in situations where the menu shows near the right edge of the screen. For example, when right-clicking the text widget, this can happen and the menu should be placed below the cursor:

screenshot-1710091877

Added the missing implementation, and changed the offset to 1 instead of 10.
@ethical-haquer
Copy link
Contributor Author

Thanks! A couple things:

* You missed one of the four menus. Run `git grep tk_popup` to find all places where menus are shown.

* These also need y offset.

Will do!

@Akuli
Copy link
Owner

Akuli commented Mar 10, 2024

IMO 10 pixels is better than 1 pixel. You got that part right initially. Sorry if I wasn't clear :)

Copy link
Owner

@Akuli Akuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I tried it on my computer and the new behavior is awesome :)

@Akuli Akuli merged commit f8f153e into Akuli:main Mar 11, 2024
18 checks passed
@ethical-haquer
Copy link
Contributor Author

Thanks! I tried it on my computer and the new behavior is awesome :)

Your welcome! I figured I had better start on something small. 🤣
Thanks for guiding me through the process and answering my numerous questions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

right-click menu placing
2 participants