Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak logic in enabling menu items #1441

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions porcupine/menubar.py
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,7 @@ def register_enabledness_check_event(event: str) -> None:
get_tab_manager().bind(event, _refresh_menu_item_enabledness, add=True)


def set_enabled_based_on_tab(path: str, callback: Callable[[tabs.Tab], bool]) -> None:
def set_enabled_based_on_tab(path: str, callback: Callable[[tabs.Tab | None], bool]) -> None:
"""Use this for disabling menu items depending on the currently selected tab.

When the selected :class:`~porcupine.tabs.Tab` changes, ``callback`` will
Expand Down Expand Up @@ -295,7 +295,7 @@ def update_enabledness(*junk: object, path: str) -> None:
index = _find_item(menu, child)
if index is None:
raise LookupError(f"menu item {path!r} not found")
if tab is not None and callback(tab):
if callback(tab):
menu.entryconfig(index, state="normal")
else:
menu.entryconfig(index, state="disabled")
Expand Down
Loading