Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of requirements.txt #1435

Merged
merged 5 commits into from
Feb 7, 2024
Merged

Get rid of requirements.txt #1435

merged 5 commits into from
Feb 7, 2024

Conversation

Akuli
Copy link
Owner

@Akuli Akuli commented Feb 7, 2024 •
edited
Loading

Now requirements-dev.txt contains all dependencies. Its purpose is so that you can get started with developing Porcupine easily.

Fixes #1381

Akuli added a commit that referenced this pull request Feb 7, 2024
@Akuli
Commit the autofix part of #1435 directly to main
5d1c053
@Akuli
Copy link
Owner Author

Akuli commented Feb 7, 2024

Remaining CI failures are unrelated.

@Akuli Akuli merged commit d6de58e into main Feb 7, 2024
5 of 18 checks passed
@Akuli Akuli deleted the bye-reqs branch February 7, 2024 10:15
@Moosems
Copy link
Contributor

Moosems commented Feb 7, 2024

Why not turn requirements-dev.txt into requirements.txt?

@Akuli
Copy link
Owner Author

Akuli commented Feb 7, 2024

I like the -dev in the name, because the file is used only for developing Porcupine. For a user, the dependencies come from pyproject.toml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Merging requirements.txt and requirements-dev.txt
2 participants
@Akuli @Moosems