-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch Dependency Management to pyproject.toml + Bonus Changes #1406
Conversation
didn't touch sphinx; everything else that could be updated was update
okay, I'm done! |
Not sure what is wrong with Windows |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of my comments are about dependency management. We can split dependency stuff to a separate PR, or do it all here, however you want.
porcu | ||
```bash | ||
python3 -m pip install -u pipx # if you don't have `pipx` already | ||
pipx install git+https://github.com/Akuli/porcupine.git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Why do we use pipx for "Other Linux distributions" but not for "Debian-based Linux distributions"?
- Why
pipx install
? I thought the whole point of pipx is that you just tell it to run a thing, and you don't have to install anything.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we use pipx for "Other Linux distributions" but not for "Debian-based Linux distributions"?
I didn't notice the Debian section 😅
I thought the whole point of pipx is that you just tell it to run a thing
The point of pipx is it handles the venv for you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Akuli AFAIK this is the last thing that needs decided to move on this. Have your concerns been addressed in the other discussions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Switching to pipx install
still feels like a downgrade to me. It isn't any less effort to run Porcupine this way with pipx, but you end up with a venv in a weird / non-obvious place. This means that after trying Porcupine for a few minutes, if you dislike it, you don't know what to delete to undo whatever pipx
did. With an explicit venv creation, everything is neatly in one place and it's very obvious how to get rid of Porcupine.
However, the pipx command is useful for people who already have/use/like pipx. Maybe we could show both ways to do this?
Co-authored-by: Akuli <[email protected]>
This seems to be no longer relevant. |
Fixes #1381
Fixes #1403
Fixes #1395
Fixes #1317
Added some docs related to #1219