Skip to content

Commit

Permalink
Tweak logic in enabling menu items
Browse files Browse the repository at this point in the history
Fixes #1422
  • Loading branch information
taahol committed Feb 9, 2024
1 parent 4e7a8a0 commit 0b82c47
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions porcupine/menubar.py
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,7 @@ def register_enabledness_check_event(event: str) -> None:
get_tab_manager().bind(event, _refresh_menu_item_enabledness, add=True)


def set_enabled_based_on_tab(path: str, callback: Callable[[tabs.Tab], bool]) -> None:
def set_enabled_based_on_tab(path: str, callback: Callable[[tabs.Tab | None], bool]) -> None:
"""Use this for disabling menu items depending on the currently selected tab.
When the selected :class:`~porcupine.tabs.Tab` changes, ``callback`` will
Expand Down Expand Up @@ -295,7 +295,7 @@ def update_enabledness(*junk: object, path: str) -> None:
index = _find_item(menu, child)
if index is None:
raise LookupError(f"menu item {path!r} not found")
if tab is not None and callback(tab):
if callback(tab):
menu.entryconfig(index, state="normal")
else:
menu.entryconfig(index, state="disabled")
Expand Down

0 comments on commit 0b82c47

Please sign in to comment.