-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: move segment manifest cache to fetch module #484
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
123 changes: 123 additions & 0 deletions
123
...src/main/java/io/aiven/kafka/tieredstorage/fetch/manifest/MemorySegmentManifestCache.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,123 @@ | ||
| /* | ||
| * Copyright 2023 Aiven Oy | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package io.aiven.kafka.tieredstorage.fetch.manifest; | ||
|
|
||
| import java.io.IOException; | ||
| import java.io.InputStream; | ||
| import java.util.Map; | ||
| import java.util.concurrent.ExecutionException; | ||
| import java.util.concurrent.ExecutorService; | ||
| import java.util.concurrent.ForkJoinPool; | ||
| import java.util.concurrent.TimeUnit; | ||
| import java.util.concurrent.TimeoutException; | ||
|
|
||
| import io.aiven.kafka.tieredstorage.config.CacheConfig; | ||
| import io.aiven.kafka.tieredstorage.manifest.SegmentManifest; | ||
| import io.aiven.kafka.tieredstorage.metrics.CaffeineStatsCounter; | ||
| import io.aiven.kafka.tieredstorage.storage.ObjectFetcher; | ||
| import io.aiven.kafka.tieredstorage.storage.ObjectKey; | ||
| import io.aiven.kafka.tieredstorage.storage.StorageBackendException; | ||
|
|
||
| import com.fasterxml.jackson.databind.ObjectMapper; | ||
| import com.github.benmanes.caffeine.cache.AsyncLoadingCache; | ||
| import com.github.benmanes.caffeine.cache.Caffeine; | ||
| import com.github.benmanes.caffeine.cache.RemovalListener; | ||
| import com.github.benmanes.caffeine.cache.Scheduler; | ||
| import com.github.benmanes.caffeine.cache.Weigher; | ||
| import org.slf4j.Logger; | ||
| import org.slf4j.LoggerFactory; | ||
|
|
||
| public class MemorySegmentManifestCache implements SegmentManifestCache { | ||
| private static final Logger log = LoggerFactory.getLogger(MemorySegmentManifestCache.class); | ||
| private static final String METRIC_GROUP = "segment-manifest-cache-metrics"; | ||
| private static final long GET_TIMEOUT_SEC = 10; | ||
| private static final long DEFAULT_MAX_SIZE = 1000L; | ||
| private static final long DEFAULT_RETENTION_MS = 3_600_000; | ||
|
|
||
| private AsyncLoadingCache<ObjectKey, SegmentManifest> cache; | ||
| final CaffeineStatsCounter statsCounter = new CaffeineStatsCounter(METRIC_GROUP); | ||
|
|
||
| final ObjectFetcher fileFetcher; | ||
| final ObjectMapper mapper; | ||
|
|
||
| public MemorySegmentManifestCache(final ObjectFetcher fileFetcher, final ObjectMapper mapper) { | ||
| this.fileFetcher = fileFetcher; | ||
| this.mapper = mapper; | ||
| } | ||
|
|
||
| public SegmentManifest get(final ObjectKey manifestKey) | ||
| throws StorageBackendException, IOException { | ||
| try { | ||
| return cache.get(manifestKey).get(GET_TIMEOUT_SEC, TimeUnit.SECONDS); | ||
| } catch (final ExecutionException e) { | ||
| // Unwrap previously wrapped exceptions if possible. | ||
| final Throwable cause = e.getCause(); | ||
|
|
||
| // We don't really expect this case, but handle it nevertheless. | ||
| if (cause == null) { | ||
| throw new RuntimeException(e); | ||
| } | ||
| if (e.getCause() instanceof StorageBackendException) { | ||
| throw (StorageBackendException) e.getCause(); | ||
| } | ||
| if (e.getCause() instanceof IOException) { | ||
| throw (IOException) e.getCause(); | ||
| } | ||
|
|
||
| throw new RuntimeException(e); | ||
| } catch (final InterruptedException | TimeoutException e) { | ||
| throw new RuntimeException(e); | ||
| } | ||
| } | ||
|
|
||
| // for testing | ||
| RemovalListener<ObjectKey, SegmentManifest> removalListener() { | ||
| return (key, content, cause) -> log.debug("Deleted cached value for key {} from cache." | ||
| + " The reason of the deletion is {}", key, cause); | ||
| } | ||
|
|
||
| private static Weigher<ObjectKey, SegmentManifest> weigher() { | ||
| return (key, value) -> 1; | ||
| } | ||
|
|
||
| protected AsyncLoadingCache<ObjectKey, SegmentManifest> buildCache(final CacheConfig config) { | ||
| final ExecutorService executor = new ForkJoinPool(); | ||
| final Caffeine<Object, Object> cacheBuilder = Caffeine.newBuilder(); | ||
| config.cacheSize().ifPresent(maximumWeight -> cacheBuilder.maximumWeight(maximumWeight).weigher(weigher())); | ||
| config.cacheRetention().ifPresent(cacheBuilder::expireAfterAccess); | ||
| final var cache = cacheBuilder.evictionListener(removalListener()) | ||
| .scheduler(Scheduler.systemScheduler()) | ||
| .executor(executor) | ||
| .recordStats(() -> statsCounter) | ||
| .buildAsync(key -> { | ||
| try (final InputStream is = fileFetcher.fetch(key)) { | ||
| return mapper.readValue(is, SegmentManifest.class); | ||
| } | ||
| }); | ||
| statsCounter.registerSizeMetric(cache.synchronous()::estimatedSize); | ||
| return cache; | ||
| } | ||
|
|
||
| @Override | ||
| public void configure(final Map<String, ?> configs) { | ||
| final var config = CacheConfig.newBuilder(configs) | ||
| .withDefaultSize(DEFAULT_MAX_SIZE) | ||
| .withDefaultRetentionMs(DEFAULT_RETENTION_MS) | ||
| .build(); | ||
| this.cache = buildCache(config); | ||
| } | ||
| } | ||
30 changes: 30 additions & 0 deletions
30
core/src/main/java/io/aiven/kafka/tieredstorage/fetch/manifest/SegmentManifestCache.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| /* | ||
| * Copyright 2024 Aiven Oy | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package io.aiven.kafka.tieredstorage.fetch.manifest; | ||
|
|
||
| import java.io.IOException; | ||
|
|
||
| import org.apache.kafka.common.Configurable; | ||
|
|
||
| import io.aiven.kafka.tieredstorage.manifest.SegmentManifest; | ||
| import io.aiven.kafka.tieredstorage.storage.ObjectKey; | ||
| import io.aiven.kafka.tieredstorage.storage.StorageBackendException; | ||
|
|
||
| public interface SegmentManifestCache extends Configurable { | ||
| SegmentManifest get(final ObjectKey manifestKey) | ||
| throws StorageBackendException, IOException; | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not new, but moving+renaming SegmentManifestProvider