Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Prevent redirection from ProtectedRoute component if there's another route change is already happening #2399

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

[Fix] Prevent redirection from ProtectedRoute component if there's another route change is already happening #2399

wants to merge 4 commits into from

Conversation

ardaerzin
Copy link
Contributor

Context

During my implementation of new tests, I'd encountered a few cases, where the redirection logic inside ProtectedRoute was cancelling direction of new users to /post-signup

What has changed

  • ProtectedRoute now listens to router events and do not perform a push, if router is already in progress of changing routes

@vercel Vercel
Copy link

vercel bot commented Dec 30, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
agenta ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2025 0:07am
agenta-documentation ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2025 0:07am

github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 30, 2024
View reviewed changes
agenta-cli/tests/baggage/app.py Dismissed Show resolved Hide resolved
@ardaerzin ardaerzin changed the base branch from main to dev December 30, 2024 10:37
@ardaerzin ardaerzin marked this pull request as ready for review December 30, 2024 12:28
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. bug Something isn't working typescript labels Dec 30, 2024
@ardaerzin ardaerzin requested a review from bekossy December 30, 2024 13:40
bekossy
bekossy requested changes Jan 1, 2025
View reviewed changes
Copy link
Member

@bekossy bekossy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, @ardaerzin! I've added a few comments for your review

@ardaerzin ardaerzin requested a review from bekossy January 2, 2025 11:59
bekossy
bekossy approved these changes Jan 2, 2025
View reviewed changes
Copy link
Member

@bekossy bekossy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM✅

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aybruhm aybruhm aybruhm left review comments

@bekossy bekossy bekossy approved these changes

Assignees
No one assigned
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files. typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ardaerzin @aybruhm @bekossy