Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: Testing - Checkpoint 1 (Web) #2398

Open
wants to merge 8 commits into
base: dev
Choose a base branch
from
Open

[Feature]: Testing - Checkpoint 1 (Web) #2398

wants to merge 8 commits into from

Conversation

ardaerzin
Copy link
Contributor

@ardaerzin ardaerzin commented Dec 30, 2024 •
edited
Loading

closes AGE-1491

What has changed?

  • playwright setup for e2e tests
    • common fixtures for common steps / checks
  • programmatic access for Cloud tests
    • via email currently using testmail
    • abstracted login steps, so that developers can focus on building actual test cases rather than repeating same steps
      • added sub flows that are related to login & new user creation -> signup-form
      • added sub flow to support setting a test LLM key at the beginning for non-cloud tests
        -command configuration to run tests against different environments
  • annotation setup v1
  • first test implementation for app creation
  • documentation on implementation and usage

@vercel Vercel
Copy link

vercel bot commented Dec 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
agenta ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 30, 2024 10:24am
agenta-documentation ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 30, 2024 10:24am

@ardaerzin ardaerzin marked this pull request as ready for review December 30, 2024 11:06
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. feature tests labels Dec 30, 2024
@ardaerzin ardaerzin requested a review from jp-agenta December 30, 2024 13:40
@ardaerzin ardaerzin self-assigned this Dec 30, 2024
jp-agenta
jp-agenta approved these changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@jp-agenta jp-agenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ardaerzin
Pretty good start for checkpoint 1 !
A few things might change when we sync about later checkpoints (tags breakdown, non-hardcoded targets, centralized traceability matrix, and others).

lgtm :)

ashrafchowdury
ashrafchowdury approved these changes Jan 2, 2025
View reviewed changes
Copy link
Collaborator

@ashrafchowdury ashrafchowdury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't gone through everything but the overview looks good to me 👍

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jp-agenta jp-agenta jp-agenta approved these changes

@ashrafchowdury ashrafchowdury ashrafchowdury approved these changes

@bekossy bekossy Awaiting requested review from bekossy

Assignees

@ardaerzin ardaerzin

Labels
feature lgtm This PR has been approved by a maintainer size:XXL This PR changes 1000+ lines, ignoring generated files. tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ardaerzin @ashrafchowdury @jp-agenta