WIP: Handling multiple instances of the Klarna Widget #2996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sponglord
requested review from
marcperez,
pabloai,
m1aw,
ribeiroguilherme and
longyulongyu
as code owners
|
sponglord
changed the title
size-limit report 📦
|
|
Size Change: +680 B (+0.09%) Total Size: 768 kB
ℹ️ View Unchanged
|
…econd or subsequent widgets being present in the same PM list
…naSDK widget if it is re-shown
|
sponglord
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PR to handle the issue with multiple instances of the Klarna widget being present in the PM list
There are 2 issues:
KlarnaWidgetit loads the KlarnaSDK, which in turn calls the callback we create (window.klarnaAsyncCallback), which initialises the KlarnaSDK.KlarnaWidgetin the PM list, initialising that will not see the KlarnaSDK calling our callback for a second time, and so the KlarnaSDK is not re-initialised with the rightsdkData.client_tokento make the correct payment.sdkData.client_tokenSo..
KlarnaWidgetcomponent it checks if it "manually" needs to initialise the KlarnaSDK widget (fixes issue 1)UIElementto allow it to run some custom logic (onPaymentMethodActive).This allows the
KlarnaWidgetto "manually" re-initialise the KlarnaSDK. (fixes issue 2)Tested scenarios
... TODO: outline the manual testing undertaken
Existing unit tests adjusted, and all pass
Fixes issue: COWEB-1468