Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ECP-9482] Refactor Header Data Builder For Transaction Clients #2819

Open
wants to merge 22 commits into
base: main
Choose a base branch
from
Open

[ECP-9482] Refactor Header Data Builder For Transaction Clients #2819

wants to merge 22 commits into from

Conversation

SushmitaThakur
Copy link
Contributor

@SushmitaThakur SushmitaThakur commented Dec 3, 2024 •
edited
Loading

Description
This PR -

  • Refactors HeaderDatabuilder to use a HeaderDataBuiderInterface that declares all the header constants.
  • Updates TransactionClients (capture/cancel/refund etc.) accordingly
  • Updates the path to header builder in di.xml and add the builder for capture, cancel, refund and paybylink
  • Updates relevant observers to use correct frontendType constant
  • Synchronises the frontendType value to default in JS renderers
  • Updates relevant unit tests
  • Adds unit tests for TransactionPaymentLinks class

Tested Scenarios

  • TransactionPayment
  • TransactionCancel
  • TransactionCapture
  • PaymentDetails Call
  • TransactionPaymentLinks

sushmita added 5 commits November 20, 2024 14:34
[ECP-9482-1] Added HeaderDataBuilderInterface, moved header builder t…
1bedb63 
…o separate directory, updated constants in the observers, updated frontend type values to `luma`, added HeaderDataBuilder in the authorization flow for cancel, capture, refund, donate, payByLink, and pos transaction clients in di.xml
[ECP-9482-1] Removed HeaderDataBuilder from pos transaction client, u…
bffe6de 
…pdated the headers in all transaction clients
[ECP-9482-1] Updated Tests
63c0cd6
[ECP-9482-1] Updated constants in data helper
66fddfc
[ECP-9482-1] Updated header in refund request options
00346a8
@SushmitaThakur SushmitaThakur requested a review from a team as a code owner December 3, 2024 12:40
@SushmitaThakur SushmitaThakur marked this pull request as draft December 3, 2024 12:40
@SushmitaThakur SushmitaThakur marked this pull request as ready for review December 4, 2024 12:37
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 11, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@SushmitaThakur SushmitaThakur marked this pull request as ready for review December 11, 2024 14:27
@SushmitaThakur SushmitaThakur changed the title [ECP-9482-1] Refactor Header Data Builder - 2 [ECP-9482] Refactor Header Data Builder For Transaction Clients Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@candemiralp candemiralp candemiralp approved these changes

@acampos1916 acampos1916 acampos1916 approved these changes

@khushboo-singhvi khushboo-singhvi khushboo-singhvi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SushmitaThakur @khushboo-singhvi @acampos1916 @candemiralp