Release v29.1.0 #1377
Merged
Release v29.1.0 #1377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jillingk
reviewed
Oct 21, 2024
README.md
Outdated
| @@ -240,7 +240,7 @@ client.setHttpClient(adyenHttpClientWithProxy); | |||
| If your proxy requires authentication, set all the settings as system properties instead (don't mix with previous approach), for example: | |||
|
|
|||
| ~~~~ java | |||
| System.setProperty("https.proxyHost", "129.0.0.1"); | |||
| System.setProperty("https.proxyHost", "129.0.1.1"); | |||
There was a problem hiding this comment.
@DjoykeAbyah this is interesting, automation changed the proxy as it is coincidentally the exact same number as the version number.. Let's change it back so we do not keep bumping the proxy along with the version :)
There was a problem hiding this comment.
I have corrected this manually. We need to look at the version bump logic and address it
AdyenAutomationBot
force-pushed
the
promote/main
branch
from
4b857eb
to
8cdbcfd
Compare
|
gcatanese
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merged pull requests to be released:
Full Changelog: v29.0.0...main