Release - dependency updates in release notes #1906
Draft
+258
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python will make it a lot easier to process the dependency update PRs. Besides, Python is easier to understand, so it should be more maintainable. COAND-1017
COAND-1017
COAND-1017
OscarSpruit
added
the
Chore
✅ No public API changes |
|
jreij
reviewed
Dec 2, 2024
| com.google.dagger:hilt-android-testing | ||
| com.google.dagger:hilt-compiler | ||
| com.google.devtools.ksp | ||
| com.google.pay.button:compose-pay-button |
There was a problem hiding this comment.
Will this be part of the SDK with Google Pay improvements PR?
There was a problem hiding this comment.
Yes, so depending on which PR we move first, we should remove it either in this PR or in the Google Pay one
There was a problem hiding this comment.
I would say remove it from here regardless so that we don't forget it
jreij
reviewed
Dec 2, 2024
| needs: [generate_version_name, publish_to_maven_central] | ||
| with: | ||
| version-name: ${{ needs.generate_version_name.outputs.version-name }} | ||
| version-name: "9.9.9" |
There was a problem hiding this comment.
No, this is for testing. I'll revert that commit later
jreij
reviewed
Dec 2, 2024
| return commit[start:end] | ||
|
|
||
| def fetch_pr(number: str) -> dict: | ||
| url = 'https://api.github.com/repos/{}/pulls/{}'.format(os.getenv('GITHUB_REPO'), number) |
There was a problem hiding this comment.
What happens if we update a dependency without using renovate? Will this script skip it?
OscarSpruit
force-pushed
the
chore/release_process_changes_dependencies
branch
2 times, most recently
from
7c94e58
to
2531a57
Compare
OscarSpruit
force-pushed
the
chore/release_process_changes_dependencies
branch
from
2531a57
to
5ab4e9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
COAND-1017