Develop disable iboutlet trailing closure (#3)

* Unpublish iboutlet with trailing closures. Use ibsubiews instead * desactivate iboutlet variants with trailing ibsubview closures due to possible missuage in edge cases
Adobels · Oct 5, 2023 · 0c158b8 · 0c158b8
1 parent 9581a5d
commit 0c158b8
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 48 deletions.
diff --git a/Sources/UIViewKit/UIViewDSL+IBOutlet.swift b/Sources/UIViewKit/UIViewDSL+IBOutlet.swift
@@ -22,51 +22,9 @@ extension UIViewDSL where Self: UIView {
         return self
     }
 
-    @discardableResult
-    public func ibOutlet(_ outlet: inout Self?, @UIViewBuilder _ content: () -> [UIView]) -> Self {
-        outlet = self
-        UIViewDSLEngine.shared.addSubviews(content, to: self)
-        return self
-    }
-
-    @discardableResult
-    public func ibOutlet(_ outlet: inout Self?, @UIViewBuilder _ content: (UIView) -> [UIView]) -> Self {
-        outlet = self
-        UIViewDSLEngine.shared.addSubviews(content, to: self)
-        return self
-    }
-
-    @discardableResult
-    public func ibOutlet(_ outlet: inout Self, @UIViewBuilder _ content: () -> [UIView]) -> Self {
-        outlet = self
-        UIViewDSLEngine.shared.addSubviews(content, to: self)
-        return self
-    }
-
-    @discardableResult
-    public func ibOutlet(_ outlet: inout Self, @UIViewBuilder _ content: (UIView) -> [UIView]) -> Self {
-        outlet = self
-        UIViewDSLEngine.shared.addSubviews(content, to: self)
-        return self
-    }
-
     @discardableResult
     public func ibOutlet(in outlet: inout [Self]) -> Self {
         outlet.append(self)
         return self
     }
-
-    @discardableResult
-    public func ibOutlet(in outlet: inout [Self], @UIViewBuilder _ content: () -> [UIView]) -> Self {
-        outlet.append(self)
-        UIViewDSLEngine.shared.addSubviews(content, to: self)
-        return self
-    }
-
-    @discardableResult
-    public func ibOutlet(in outlet: inout [Self], @UIViewBuilder _ content: (UIView) -> [UIView]) -> Self {
-        outlet.append(self)
-        UIViewDSLEngine.shared.addSubviews(content, to: self)
-        return self
-    }
 }
diff --git a/Tests/UIViewKitTests/IBOutletTests.swift b/Tests/UIViewKitTests/IBOutletTests.swift
@@ -40,7 +40,7 @@ class IBOutletTests: XCTestCase {
 
         var view = UIView()
 
-        let newView = UIView().ibOutlet(&view) {
+        let newView = UIView().ibOutlet(&view).ibSubviews {
             UIView()
         }
 
@@ -51,7 +51,7 @@ class IBOutletTests: XCTestCase {
 
         var view = UIView()
 
-        let newView = UIView().ibOutlet(&view) { _ in
+        let newView = UIView().ibOutlet(&view).ibSubviews { _ in
             UIView()
         }
 
@@ -61,7 +61,7 @@ class IBOutletTests: XCTestCase {
     func testIBOutletInWithTrailingClosureOfIbSubviews() throws {
         var views: [UIView] = []
 
-        let newView = UIView().ibOutlet(in: &views) {
+        let newView = UIView().ibOutlet(in: &views).ibSubviews {
             UIView()
         }
 
@@ -72,7 +72,7 @@ class IBOutletTests: XCTestCase {
     func testIBOutletInWithTrailingClosureOfIbSubviewsAndSuperview() throws {
         var views: [UIView] = []
 
-        let newView = UIView().ibOutlet(in: &views) { _ in
+        let newView = UIView().ibOutlet(in: &views).ibSubviews { _ in
             UIView()
         }
 
@@ -83,7 +83,7 @@ class IBOutletTests: XCTestCase {
     func testIBOutletWithForceUnwrapWithTrailingClosureOfIbSubviews() async throws {
         var view: UIView!
 
-        let newView = UIView().ibOutlet(&view) {
+        let newView = UIView().ibOutlet(&view).ibSubviews {
             UIView()
         }
 
@@ -93,7 +93,7 @@ class IBOutletTests: XCTestCase {
     func testIBOutletWithForceUnwrapWithTrailingClosureOfIbSubviewsAndSuperview() async throws {
         var view: UIView!
 
-        let newView = UIView().ibOutlet(&view) { _ in
+        let newView = UIView().ibOutlet(&view).ibSubviews { _ in
             UIView()
         }