Expanded support for map type in DynamoDB #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes:
- added TYPE_MAP constant
- added recursive parsing of map in parseAttributes
- follow nested structs during output to map[string]interface{}
- expanded testing of Query/Scan operations so that Map is covered
- added dummy interface for UpdateExpressionUpdateAttributes and
failing unit test for it
… grammar The existing UpdateAttributes method on Table could potentially be modified to support a limited subset of UpdateExpressions, but it can't currently support semantics like "SET #key1=:val1, DELETE #key2=:val2" that are permitted by the DynamoDB API. Providing a method that allows us to pass an UpdateExpression struct will support arbitrary UpdateExpressions at the cost of the complexity to actually write one. The added complexity only appears when we actually need it, so this seems like a good trade off. Examples are provided in the associated test code.
|
It looks reasonable to me, but I'm really only intimately familiar with the Document/dynamizer functions. |
alimoeeny
added a commit
that referenced
this pull request
Feb 10, 2015
Expanded support for map type in DynamoDB
|
I've got working code in my project using at least some of this now, so that's a good sign. Over the next week or two I'll be exercising it quite a bit, so hopefully if there are any bugs sneaking around I'll find them first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #308
This PR provides a UpdateExpressionUpdateAttributes method on Table that will allow us to support arbitrary UpdateExpressions to the underlying UpdateItem API endpoint.
The existing UpdateAttributes method on Table could potentially be modified to support a limited subset of UpdateExpressions, but it can't support semantics like "SET #key1.#key2=:val1" that are permitted by the DynamoDB API. Adding a new method rather than extending the existing interface will allow consuming code to avoid the complexity of writing an UpdateExpression unless it's actually needed to express operations on fields of a map (or multiple operations such as a SET and DELETE in the same call). Examples are provided in the associated test code.
Includes:
I've run the full dynamodb package's test suite via
go test -check.vv -amazon -local