Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix GNOME desktop entry instructions #141

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

meonkeys
Copy link

@meonkeys meonkeys commented Dec 9, 2024

Gotta use absolute paths in Exec in .desktop files or they don't show up automatically. Not sure if this is true for everyone/always, but it was for me.

Sources:

https://bbs.archlinux.org/viewtopic.php?id=256867

https://discourse.gnome.org/t/application-entries-desktop-not-displayed/3670

https://discussion.fedoraproject.org/t/how-to-create-a-desktop-file-to-show-up-among-my-apps/128596/5

These sources indicate the underlying issue appears has to do with an issue with the user's non-interactive path, but I think the issue might actually be the tilde is not expanded. I didn't attempt to debug further, I just used an absolute path and it worked (they immediately started showing up when I press the "Super" key). Using an absolute path seems like the safer (and more annoying) way to go to make it work for most people. I do wish tilde worked more reliably.

FFR, my desktop right now is GNOME, as shipped with 64-bit Ubuntu 22.04 LTS. I think that means GNOME 3 and Wayland.


Important

Update GNOME desktop entry instructions to use absolute paths in src/running-on-gnome.rst.

  • Documentation:
    • Update src/running-on-gnome.rst to use absolute paths in Exec field of .desktop files for GNOME desktop entries.
    • Replace Exec="~/.local/opt/activitywatch/start.sh" with Exec="/home/user/.local/opt/activitywatch/start.sh".
    • Replace Exec="~/.local/opt/activitywatch/kill.sh" with Exec="/home/user/.local/opt/activitywatch/kill.sh".

This description was created by Ellipsis for 8389e96. It will automatically update as commits are pushed.

Gotta use absolute paths in `Exec` in `.desktop` files or they don't show up automatically. Not sure if this is true for everyone/always, but it was for me.

Sources:

https://bbs.archlinux.org/viewtopic.php?id=256867

https://discourse.gnome.org/t/application-entries-desktop-not-displayed/3670

https://discussion.fedoraproject.org/t/how-to-create-a-desktop-file-to-show-up-among-my-apps/128596/5

These sources indicate the underlying issue appears has to do with an issue with the user's non-interactive path, but I think the issue might actually be the tilde is not expanded. I didn't attempt to debug further, I just used an absolute path and it worked. Seems like the safer (and more annoying) way to go to make it work for most people. I do with tilde worked more reliably.

FFR, my desktop right now is GNOME, as shipped with 64-bir Ubuntu 22.04 LTS. I think that means GNOME 3 and Wayland.
Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 8389e96 in 33 seconds

More details
  • Looked at 31 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. src/running-on-gnome.rst:39
  • Draft comment:
    Remove the double quotes around the Exec path as they are unnecessary and could cause issues.
  Exec=/home/user/.local/opt/activitywatch/start.sh
  • Reason this comment was not posted:
    Comment looked like it was already resolved.
2. src/running-on-gnome.rst:54
  • Draft comment:
    Remove the double quotes around the Exec path as they are unnecessary and could cause issues.
  Exec=/home/user/.local/opt/activitywatch/kill.sh
  • Reason this comment was not posted:
    Marked as duplicate.

Workflow ID: wflow_15i3cuVwQpfy3Aud


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant