Allow manually configuring the hostname #143
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without any obvious ability for the extension to determine the machine's hostname automatically, the best available option seems to be to allow users to configure it manually. A field is added to the extension popup to configure the hostname. The field is blank by default, and the updates were designed to ensure that the behaviour if the hostname is not set will be unchanged (so people using workflows that expect browser data in the "unknown" host bucket won't see anything break; they can set the hostname once they're prepared to do so). Fixes ActivityWatch#132
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 53e1345 in 1 minute and 19 seconds
More details
- Looked at
139lines of code in3files - Skipped
0files when reviewing. - Skipped posting
2drafted comments based on config settings.
1. src/client.js:82
- Draft comment:
Use!==for strict comparison to avoid type coercion issues.
if (hostname !== "")
- Reason this comment was not posted:
Marked as duplicate.
2. static/popup.js:42
- Draft comment:
Use!==for strict comparison to avoid type coercion issues.
hostnameTextbox.value = obj.hostname !== "" ? obj.hostname : "";
- Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_MUjTg3FZ8rM1bBz4
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| }); | ||
| }, | ||
|
|
||
| getBucketId: function () { | ||
| return "aw-watcher-web-" + client.browserName.toLowerCase(); | ||
| if (client.hostname != "") |
There was a problem hiding this comment.
Use !== for strict comparison to avoid type coercion issues.
Suggested change
| if (client.hostname != "") | |
| if (client.hostname !== "") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without any obvious ability for the extension to determine the machine's hostname automatically, the best available option seems to be to allow users to configure it manually. A field is added to the extension popup to configure the hostname.
The field is blank by default, and the updates were designed to ensure that the behaviour if the hostname is not set will be unchanged (so people using workflows that expect browser data in the "unknown" host bucket won't see anything break; they can set the hostname once they're prepared to do so).
Fixes #132
If anyone using Firefox wants to test this out, I've created a signed version of the extension from this PR: aw-watcher-web-9462f488983245cbad32-0.4.8.9999.xpi. Please note that this extension is signed using my personal key and uses a different extension ID from the official ActivityWatch extension - as a result it will install alongside the official extension and will not share settings.
Important
Adds manual hostname configuration to the extension, allowing users to set a hostname via the popup UI, while maintaining default behavior if not set.
client.jsusing a new input field in the popup.Hostnameinput field andSavebutton inpopup.html.popup.jsto handle hostname input and save functionality.setup()andgetBucketId()inclient.jsto incorporate hostname logic.This description was created by
for 53e1345. It will automatically update as commits are pushed.