Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add prettier and format project #100

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mafredri
Copy link

@mafredri mafredri commented Jan 22, 2023

This PR adds prettier as a dev-dependency and slightly adjusts its default settings so that project-wide changes are minimal.

  • Add prettier
  • Add make format command
  • Change markdown .editorconfig from 4 to 2 spaces which best matches existing formatting
  • Add json to editorconfig and format all json files with 2 spaces (to match manifest.json)

Why this I make this PR?

I started to make some changes (with the goal of building for Safari), but the inconsisten formatting/style kind of got in my way 😅.

Hope you can consider this, and I'm open to changing any settings you don't agree with. (PS. I suggest reviewing without whitespace changes.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant