-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: switched to source-based coverage #192
Conversation
Getting a better error message for the blinking macOS builds (#180):
I assume we'll have to somehow discard the cache if we're using a new compiler. Weird that cargo/rustc doesn't do this itself. |
Codecov Report
@@ Coverage Diff @@
## master #192 +/- ##
==========================================
+ Coverage 53.60% 59.74% +6.13%
==========================================
Files 58 42 -16
Lines 7687 4308 -3379
Branches 1821 0 -1821
==========================================
- Hits 4121 2574 -1547
+ Misses 3559 1734 -1825
+ Partials 7 0 -7
Continue to review full report at Codecov.
|
@@ -67,7 +70,7 @@ jobs: | |||
export PATH=$PATH:. | |||
make coverage-lcov COVERAGE_CACHE=1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@johan-bjareholt Why is COVERAGE_CACHE set?
Edit: Nvm, I think I get it.
@johan-bjareholt It seems like coverage reporting is consistent now (at least from the two commits in this PR 🤞)... I will go ahead and merge this so I rebase another PR and hopefully get reasonable results. |
From looking at the rebased #185 it looks like coverage works properly now 🎉 Hoping it stays that way 🤞 |
Largely based on how grcov themselves do it: https://github.com/mozilla/grcov/blob/master/.travis.yml
From mozilla/grcov@e98d5dd, it seems we can go even further and remove
CARGO_INCREMENTAL
andRUSTDOCFLAGS
.Hopefully helps with #189
Screenshot of HTML report when I run locally. Note that
source-based coveragegrcov doesn't support branch coverage (I asked them about it in mozilla/grcov#520):