Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated #1119

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

updated #1119

wants to merge 2 commits into from

Conversation

JM-JamalMustafa
Copy link

@JM-JamalMustafa JM-JamalMustafa commented Dec 10, 2024

  • create a centralized server
  • integrated Auth Api in it
  • created a gui for login change pass in the trayicon

Important

Create centralized server with integrated Auth API and GUI for login and password change in tray icon.

  • Centralized Server:
    • Created a centralized server to manage application functionalities.
  • Auth API Integration:
    • Integrated authentication API into the centralized server for user management.
  • GUI Enhancements:
    • Added GUI for login and password change in the tray icon.
  • Submodule Updates:
    • Updated submodules aw-client, aw-core, aw-notify, aw-qt, and aw-server to latest commits.

This description was created by Ellipsis for f88b8f2. It will automatically update as commits are pushed.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to f88b8f2 in 10 seconds

More details
  • Looked at 39 lines of code in 5 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. aw-client:1
  • Draft comment:
    The PR description mentions creating a centralized server and integrating an Auth API, but the changes only update submodule commits. Please ensure the description accurately reflects the changes made.
  • Reason this comment was not posted:
    Comment did not seem useful.

Workflow ID: wflow_i8ELFqSjWHX532QW


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@JM-JamalMustafa
Copy link
Author

why i dont have acess ?

@ErikBjare
Copy link
Member

What are you trying to do here?

@JM-JamalMustafa
Copy link
Author

i have created a centralized server separately and integrate in client then give options in the tray icon like login, rejister etc
when ever the user login it will push data to the centralized server and when logout it will stop pushing

@ErikBjare
Copy link
Member

Interesting! I can't see the changes you've made in the submodules because you have not pushed them.

@JM-JamalMustafa
Copy link
Author

JM-JamalMustafa commented Dec 12, 2024

the centralized server is not pushed but i just pushed the activity watch with integration i will deploy the Centralized server on aws, see the changes in trayicon.

  • when user login scheduler start and start hitting the submit endpoint of centralized server
  • and when logout schedular stops
    aw

@ErikBjare
Copy link
Member

ErikBjare commented Dec 12, 2024

the centralized server is not pushed

Please note the following license terms stipulated by the MPL2.0 license:

You must publish changes you make to the source code (if you intend to distribute it)
https://docs.activitywatch.net/en/latest/forking.html

This applies to changes in the ActivityWatch source files, not extra files you've written.
But if you don't intend to distribute it, you have no such obligation.


i just pushed the activity watch with integration i will deploy the Centralized server on aws, see the changes in trayicon

This PR makes no sense if you don't also push the modules. Not saying we would merge it, but would be interesting to read.

@JM-JamalMustafa
Copy link
Author

Thank you so much for your guide i will make changes in my fork as early as possible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants