-
-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated #1119
base: master
Are you sure you want to change the base?
updated #1119
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to f88b8f2 in 10 seconds
More details
- Looked at
39
lines of code in5
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. aw-client:1
- Draft comment:
The PR description mentions creating a centralized server and integrating an Auth API, but the changes only update submodule commits. Please ensure the description accurately reflects the changes made. - Reason this comment was not posted:
Comment did not seem useful.
Workflow ID: wflow_i8ELFqSjWHX532QW
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
why i dont have acess ? |
What are you trying to do here? |
i have created a centralized server separately and integrate in client then give options in the tray icon like login, rejister etc |
Interesting! I can't see the changes you've made in the submodules because you have not pushed them. |
Please note the following license terms stipulated by the MPL2.0 license:
This applies to changes in the ActivityWatch source files, not extra files you've written.
This PR makes no sense if you don't also push the modules. Not saying we would merge it, but would be interesting to read. |
Thank you so much for your guide i will make changes in my fork as early as possible |
Important
Create centralized server with integrated Auth API and GUI for login and password change in tray icon.
aw-client
,aw-core
,aw-notify
,aw-qt
, andaw-server
to latest commits.This description was created by for f88b8f2. It will automatically update as commits are pushed.