AddCustomBrowserByUserAgent will always override regardless of device #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…isn't a iphone. Rename the return url from iosReturnUrl to ReturnUrl
…bynactive/ActiveLogin.Authentication into #442_custom_redirect_override
PeterOrneholm
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the custom redirect part of the code to be able to override redirects even if it isn't an iphone and rename the return url from iosReturnUrl to ReturnUrl.
This makes it possible for TWA (wrapped PWA) to use a user agent without faking being anything else.
This PR fixes #442 .