Add extension point for refresh behavior on iOS #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds an extension point for controlling the refresh browser behaviour when returning from the BankID app. The problem we are trying to solve is that when starting the flow from a native iOS app using an embedded view like ASWebAuthenticationSession, we do not want to refresh the browser. With the new IReloadPageOnReturnFromBankIdApp interface, we can simply disable the refresh.
This patch adds an extension point for controlling the refresh browser behaviour when returning from the BankID app. The problem we are trying to solve is that when starting the flow from a native iOS app using an embedded view like ASWebAuthenticationSession, we do not want to refresh the browser. With the new method IBankIdLauncherCustomAppCallback.ReloadPageOnReturnFromBankIdApp, we can simply disable the refresh.
|
Thanks, great with contributions form the community! |
|
Looking at this now, great work. Will merge and make a few tweaks in another bransch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds an extension point for controlling the refresh browser behaviour when returning from the BankID app.
The problem we are trying to solve is that when starting the flow from a native iOS app using an embedded view like
ASWebAuthenticationSession, we do not want to refresh the browser. With the new IReloadPageOnReturnFromBankIdApp interface, we can simply disable the refresh.
This PR fixes #423.