Bump to version 7 (#416)

* Add missing Async prefix * Bump version * Add info on breaking change
ActiveLogin · Jun 30, 2023 · f0e0d20 · f0e0d20
1 parent 048180d
commit f0e0d20
Show file tree

Hide file tree

Showing 8 changed files with 9 additions and 7 deletions.
diff --git a/BREAKINGCHANGES.md b/BREAKINGCHANGES.md
@@ -43,7 +43,9 @@ Some API changes (as described above) propagates to the options you can customiz
 
 - `BankIdAllowBiometric` is removed and replaced by `BankIdRequirePinCode`. This has the opposite meaning as the old option, so be sure to update your code if you have used this.
 
+### IBankIdLauncher.GetLaunchInfo is now async
 
+The method `GetLaunchInfo` on `IBankIdLauncher` is now renamed into `GetLaunchInfoAsync` and made async to allow for dynamic retreival.
 
 ## Version 6.0.3
 

diff --git a/src/ActiveLogin.Authentication.BankId.Core/Flow/BankIdFlowService.cs b/src/ActiveLogin.Authentication.BankId.Core/Flow/BankIdFlowService.cs
@@ -169,7 +169,7 @@ private Task<BankIdLaunchInfo> GetBankIdLaunchInfo(string redirectUrl, string au
     {
         var launchUrlRequest = new LaunchUrlRequest(redirectUrl, autoStartToken);
 
-        return _bankIdLauncher.GetLaunchInfo(launchUrlRequest);
+        return _bankIdLauncher.GetLaunchInfoAsync(launchUrlRequest);
     }
 
     public async Task<BankIdFlowCollectResult> Collect(string orderRef, int autoStartAttempts, BankIdFlowOptions flowOptions)

diff --git a/src/ActiveLogin.Authentication.BankId.Core/Launcher/BankIdDevelopmentLauncher.cs b/src/ActiveLogin.Authentication.BankId.Core/Launcher/BankIdDevelopmentLauncher.cs
@@ -4,7 +4,7 @@ internal class BankIdDevelopmentLauncher : IBankIdLauncher
 {
     private const string DevelopmentLaunchUrl = "#";
 
-    public Task<BankIdLaunchInfo> GetLaunchInfo(LaunchUrlRequest request)
+    public Task<BankIdLaunchInfo> GetLaunchInfoAsync(LaunchUrlRequest request)
     {
         // Always stay on same page, without reloading, in simulated mode
         return Task.FromResult(new BankIdLaunchInfo(DevelopmentLaunchUrl, false, false));

diff --git a/src/ActiveLogin.Authentication.BankId.Core/Launcher/BankIdLauncher.cs b/src/ActiveLogin.Authentication.BankId.Core/Launcher/BankIdLauncher.cs
@@ -29,7 +29,7 @@ public BankIdLauncher(IBankIdSupportedDeviceDetector bankIdSupportedDeviceDetect
         _customAppCallbacks = customAppCallbacks.ToList();
     }
 
-    public async Task<BankIdLaunchInfo> GetLaunchInfo(LaunchUrlRequest request)
+    public async Task<BankIdLaunchInfo> GetLaunchInfoAsync(LaunchUrlRequest request)
     {
         var detectedDevice = _bankIdSupportedDeviceDetector.Detect();
         var deviceMightRequireUserInteractionToLaunch = GetDeviceMightRequireUserInteractionToLaunchBankIdApp(detectedDevice);

diff --git a/src/ActiveLogin.Authentication.BankId.Core/Launcher/IBankIdLauncher.cs b/src/ActiveLogin.Authentication.BankId.Core/Launcher/IBankIdLauncher.cs
@@ -10,5 +10,5 @@ public interface IBankIdLauncher
     /// </summary>
     /// <param name="request">Launch info</param>
     /// <returns></returns>
-    Task<BankIdLaunchInfo> GetLaunchInfo(LaunchUrlRequest request);
+    Task<BankIdLaunchInfo> GetLaunchInfoAsync(LaunchUrlRequest request);
 }
diff --git a/src/Directory.Build.props b/src/Directory.Build.props
@@ -15,7 +15,7 @@
         <PackageId>$(AssemblyName)</PackageId>
 
         <VersionPrefix>7.0.0</VersionPrefix>
-        <VersionSuffix>rc-1</VersionSuffix>
+        <!--<VersionSuffix>rc-1</VersionSuffix>-->
         <AssemblyVersion>7.0.0.0</AssemblyVersion>
         <FileVersion Condition="'$(BUILD_BUILDNUMBER)' == ''">$(VersionPrefix).0</FileVersion>
         <FileVersion Condition="'$(BUILD_BUILDNUMBER)' != ''">$(VersionPrefix).$(BUILD_BUILDNUMBER)</FileVersion>

diff --git a/test/ActiveLogin.Authentication.BankId.AspNetCore.Test/Helpers/TestBankIdLauncher.cs b/test/ActiveLogin.Authentication.BankId.AspNetCore.Test/Helpers/TestBankIdLauncher.cs
@@ -6,7 +6,7 @@ namespace ActiveLogin.Authentication.BankId.AspNetCore.Test.Helpers;
 
 internal class TestBankIdLauncher : IBankIdLauncher
 {
-    public Task<BankIdLaunchInfo> GetLaunchInfo(LaunchUrlRequest request)
+    public Task<BankIdLaunchInfo> GetLaunchInfoAsync(LaunchUrlRequest request)
     {
         // Always redirect back without user interaction in simulated mode
         return Task.FromResult(new BankIdLaunchInfo(request.RedirectUrl, false, false));

diff --git a/test/ActiveLogin.Authentication.BankId.Core.Test/Helpers/TestBankIdLauncher.cs b/test/ActiveLogin.Authentication.BankId.Core.Test/Helpers/TestBankIdLauncher.cs
@@ -6,7 +6,7 @@ namespace ActiveLogin.Authentication.BankId.Core.Test.Helpers;
 
 internal class TestBankIdLauncher : IBankIdLauncher
 {
-    public Task<BankIdLaunchInfo> GetLaunchInfo(LaunchUrlRequest request)
+    public Task<BankIdLaunchInfo> GetLaunchInfoAsync(LaunchUrlRequest request)
     {
         // Always redirect back without user interaction in simulated mode
         return Task.FromResult(new BankIdLaunchInfo(request.RedirectUrl, false, false));