Feature/version 10 release (#469)

* Remove version prefix, update release notes. * Do not set allowed risk level if not specified. * Update breaking changes. * Upgrade version of GitHub action upload-artifact from v2 to v3. * Upgrade NuGet packages. --------- Co-authored-by: Elin Fokine <[email protected]>
ActiveLogin · Sep 27, 2024 · 94c6ef3 · 94c6ef3
1 parent aafc9ce
commit 94c6ef3
Show file tree

Hide file tree

Showing 17 changed files with 32 additions and 28 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -72,7 +72,7 @@ jobs:
         shell: pwsh
 
       - name: Upload packages
-        uses: actions/upload-artifact@v2
+        uses: actions/upload-artifact@v3
         with: 
             name: ${{ matrix.artifactName }}
             path: |
@@ -141,7 +141,7 @@ jobs:
         shell: pwsh
 
       - name: Upload samples
-        uses: actions/upload-artifact@v2
+        uses: actions/upload-artifact@v3
         with: 
           name: ${{ matrix.artifactName }}
           path: ${{ runner.temp }}/zip
diff --git a/BREAKINGCHANGES.md b/BREAKINGCHANGES.md
@@ -25,8 +25,7 @@ Breaking changes between version 10.0.0 and 9.0.0
 * Remove policy handling from API library into Core
 * Fall back to mobile BankID policy for OtherDevice flow
 * Enum for setting policy instead of string
-* Allow only low risk level transactions by default.
-* Replaced expired embedded BankID certificate for test environment FPTestcert4_20220818.p12 with new certificate from BankID FPTestcert5_20240610.p12.
+* Replace embedded BankID certificate for the test environment FPTestcert4_20220818.p12, with the three new versions of the client certificate FPTestcert5_20240610.p12, FPTestcert5_20240610.pem and FPTestcert5_20240610-legacy.pfx. Make it configurable which version to use. For compatibility reasons use FPTestcert5_20240610-legacy.pfx by default.
 
 ---
 

diff --git a/samples/IdentityServer.ServerSample/IdentityServer.ServerSample.csproj b/samples/IdentityServer.ServerSample/IdentityServer.ServerSample.csproj
@@ -19,7 +19,7 @@
     </PropertyGroup>
 
     <ItemGroup>
-        <PackageReference Include="Duende.IdentityServer" Version="7.0.6"/>
+        <PackageReference Include="Duende.IdentityServer" Version="7.0.7" />
         <PackageReference Include="Microsoft.ApplicationInsights.AspNetCore" Version="2.22.0" />
         <PackageReference Include="Microsoft.AspNetCore.Mvc.Razor.RuntimeCompilation" Version="8.0.8" />
         <PackageReference Include="Microsoft.Extensions.Logging.ApplicationInsights" Version="2.22.0" />

diff --git a/...ogin.Authentication.BankId.AspNetCore/ActiveLogin.Authentication.BankId.AspNetCore.csproj b/...ogin.Authentication.BankId.AspNetCore/ActiveLogin.Authentication.BankId.AspNetCore.csproj
@@ -55,7 +55,7 @@
     </ItemGroup>
 
     <ItemGroup>
-        <PackageReference Include="Microsoft.TypeScript.MSBuild" Version="5.5.3">
+        <PackageReference Include="Microsoft.TypeScript.MSBuild" Version="5.6.2">
             <PrivateAssets>all</PrivateAssets>
             <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
         </PackageReference>

diff --git a/src/ActiveLogin.Authentication.BankId.AspNetCore/Auth/BankIdAuthOptions.cs b/src/ActiveLogin.Authentication.BankId.AspNetCore/Auth/BankIdAuthOptions.cs
@@ -37,7 +37,7 @@ public class BankIdAuthOptions : RemoteAuthenticationOptions
     /// the transaction will be blocked. The risk indication requires that the endUserIp is correct.
     /// An incorrect IP-address will result in legitimate transactions being blocked.
     /// </summary>
-    public BankIdAllowedRiskLevel BankIdAllowedRiskLevel { get; set; } = BankIdAllowedRiskLevel.Low;
+    public BankIdAllowedRiskLevel BankIdAllowedRiskLevel { get; set; } = BankIdAllowedRiskLevel.NoRiskLevel;
 
     /// <summary>
     /// Auto launch the BankID app on the current device.

diff --git a/...uthentication.BankId.AspNetCore/DataProtection/Serialization/BankIdUiOptionsSerializer.cs b/...uthentication.BankId.AspNetCore/DataProtection/Serialization/BankIdUiOptionsSerializer.cs
@@ -30,7 +30,7 @@ protected override BankIdUiOptions Read(BinaryReader reader)
                                     .Select(Enum.Parse<BankIdCertificatePolicy>)
                                     .ToList();
 
-        var riskLevel = Enum.TryParse<BankIdAllowedRiskLevel>(reader.ReadString(), out var allowedRiskLevel) ? allowedRiskLevel : BankIdAllowedRiskLevel.Low;
+        var riskLevel = Enum.TryParse<BankIdAllowedRiskLevel>(reader.ReadString(), out var allowedRiskLevel) ? allowedRiskLevel : BankIdAllowedRiskLevel.NoRiskLevel;
 
         return new BankIdUiOptions(
             certificatePolicies,

diff --git a/src/ActiveLogin.Authentication.BankId.AspNetCore/Sign/BankIdSignOptions.cs b/src/ActiveLogin.Authentication.BankId.AspNetCore/Sign/BankIdSignOptions.cs
@@ -28,7 +28,7 @@ public class BankIdSignOptions
     /// the transaction will be blocked. The risk indication requires that the endUserIp is correct.
     /// An incorrect IP-address will result in legitimate transactions being blocked.
     /// </summary>
-    public BankIdAllowedRiskLevel BankIdAllowedRiskLevel { get; set; } = BankIdAllowedRiskLevel.Low;
+    public BankIdAllowedRiskLevel BankIdAllowedRiskLevel { get; set; } = BankIdAllowedRiskLevel.NoRiskLevel;
 
     /// <summary>
     /// Auto launch the BankID app on the current device.

diff --git a/...uthentication.BankId.AzureKeyVault/ActiveLogin.Authentication.BankId.AzureKeyVault.csproj b/...uthentication.BankId.AzureKeyVault/ActiveLogin.Authentication.BankId.AzureKeyVault.csproj
@@ -7,7 +7,7 @@
     </PropertyGroup>
 
     <ItemGroup>
-        <PackageReference Include="Azure.Identity" Version="1.12.0" />
+        <PackageReference Include="Azure.Identity" Version="1.12.1" />
         <PackageReference Include="Microsoft.SourceLink.GitHub" Version="8.0.0" PrivateAssets="all" />
     </ItemGroup>
 

diff --git a/src/ActiveLogin.Authentication.BankId.Core/Flow/BankIdFlowService.cs b/src/ActiveLogin.Authentication.BankId.Core/Flow/BankIdFlowService.cs
@@ -100,7 +100,7 @@ private async Task<AuthRequest> GetAuthRequest(BankIdFlowOptions flowOptions)
     {
         var endUserIp = _bankIdEndUserIpResolver.GetEndUserIp();
         var resolvedCertificatePolicies = GetResolvedCertificatePolicies(flowOptions);
-        var resolvedRiskLevel = flowOptions.AllowedRiskLevel.ToString().ToLower();
+        var resolvedRiskLevel = flowOptions.AllowedRiskLevel == Risk.BankIdAllowedRiskLevel.NoRiskLevel ? null : flowOptions.AllowedRiskLevel.ToString().ToLower();
 
         var authRequestRequirement = new Requirement(resolvedCertificatePolicies, resolvedRiskLevel, flowOptions.RequirePinCode, flowOptions.RequireMrtd);
 

diff --git a/src/ActiveLogin.Authentication.BankId.Core/Risk/BankIdAllowedRiskLevel.cs b/src/ActiveLogin.Authentication.BankId.Core/Risk/BankIdAllowedRiskLevel.cs
@@ -10,5 +10,10 @@ public enum BankIdAllowedRiskLevel
     /// <summary>
     /// Accept low and moderate risk orders
     /// </summary>
-    Moderate
+    Moderate,
+
+    /// <summary>
+    /// No risk level is set and the BankID service will not block any order regardless of the risk indication.
+    /// </summary>
+    NoRiskLevel
 }
diff --git a/src/Directory.Build.props b/src/Directory.Build.props
@@ -15,7 +15,7 @@
         <PackageId>$(AssemblyName)</PackageId>
 
         <VersionPrefix>10.0.0</VersionPrefix>
-        <VersionSuffix>rc-2</VersionSuffix>
+        <!--<VersionSuffix>rc-2</VersionSuffix>-->
         <AssemblyVersion>10.0.0.0</AssemblyVersion>
         <FileVersion Condition="'$(BUILD_BUILDNUMBER)' == ''">$(VersionPrefix).0</FileVersion>
         <FileVersion Condition="'$(BUILD_BUILDNUMBER)' != ''">$(VersionPrefix).$(BUILD_BUILDNUMBER)</FileVersion>

diff --git a/...iveLogin.Authentication.BankId.Api.Test/ActiveLogin.Authentication.BankId.Api.Test.csproj b/...iveLogin.Authentication.BankId.Api.Test/ActiveLogin.Authentication.BankId.Api.Test.csproj
@@ -4,9 +4,9 @@
     </PropertyGroup>
 
     <ItemGroup>
-        <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.11.0" />
-        <PackageReference Include="Moq" Version="4.20.70" />
-        <PackageReference Include="xunit" Version="2.9.0" />
+        <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.11.1" />
+        <PackageReference Include="Moq" Version="4.20.72" />
+        <PackageReference Include="xunit" Version="2.9.2" />
         <PackageReference Include="xunit.runner.visualstudio" Version="2.8.2">
             <PrivateAssets>all</PrivateAssets>
             <IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>

diff --git a/...ntication.BankId.AspNetCore.Test/ActiveLogin.Authentication.BankId.AspNetCore.Test.csproj b/...ntication.BankId.AspNetCore.Test/ActiveLogin.Authentication.BankId.AspNetCore.Test.csproj
@@ -8,9 +8,9 @@
         <PackageReference Include="AngleSharp" Version="1.1.2" />
         <PackageReference Include="Microsoft.AspNetCore.Mvc.Testing" Version="8.0.8" />
         <PackageReference Include="Microsoft.AspNetCore.TestHost" Version="8.0.8" />
-        <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.11.0" />
-        <PackageReference Include="Moq" Version="4.20.70" />
-        <PackageReference Include="xunit" Version="2.9.0" />
+        <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.11.1" />
+        <PackageReference Include="Moq" Version="4.20.72" />
+        <PackageReference Include="xunit" Version="2.9.2" />
         <PackageReference Include="xunit.runner.visualstudio" Version="2.8.2">
             <PrivateAssets>all</PrivateAssets>
             <IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>

diff --git a/...ation.BankId.AspNetCore.Test/ClaimsTransformation/BankIdDefaultClaimsTransformer_Tests.cs b/...ation.BankId.AspNetCore.Test/ClaimsTransformation/BankIdDefaultClaimsTransformer_Tests.cs
@@ -169,7 +169,7 @@ private async Task<List<Claim>> TransformClaims(BankIdClaimsTransformationContex
 
     private void AssertClaim(List<Claim> claims, string type, string value)
     {
-        Assert.NotEmpty(claims.Where(x => x.Type == type && x.Value == value));
+        Assert.Contains(claims, x => x.Type == type && x.Value == value);
     }
 
     private void AssertNoClaim(List<Claim> claims, string type)

diff --git a/...ion.BankId.AzureKeyVault.Test/ActiveLogin.Authentication.BankId.AzureKeyVault.Test.csproj b/...ion.BankId.AzureKeyVault.Test/ActiveLogin.Authentication.BankId.AzureKeyVault.Test.csproj
@@ -4,8 +4,8 @@
     </PropertyGroup>
 
     <ItemGroup>
-        <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.11.0" />
-        <PackageReference Include="xunit" Version="2.9.0" />
+        <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.11.1" />
+        <PackageReference Include="xunit" Version="2.9.2" />
         <PackageReference Include="xunit.runner.visualstudio" Version="2.8.2">
             <PrivateAssets>all</PrivateAssets>
             <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>

diff --git a/...eLogin.Authentication.BankId.Core.Test/ActiveLogin.Authentication.BankId.Core.Test.csproj b/...eLogin.Authentication.BankId.Core.Test/ActiveLogin.Authentication.BankId.Core.Test.csproj
@@ -5,9 +5,9 @@
 
 
     <ItemGroup>
-        <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.11.0" />
-        <PackageReference Include="Moq" Version="4.20.70" />
-        <PackageReference Include="xunit" Version="2.9.0" />
+        <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.11.1" />
+        <PackageReference Include="Moq" Version="4.20.72" />
+        <PackageReference Include="xunit" Version="2.9.2" />
         <PackageReference Include="xunit.runner.visualstudio" Version="2.8.2">
             <PrivateAssets>all</PrivateAssets>
             <IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>

diff --git a/...uthentication.BankId.UAParser.Test/ActiveLogin.Authentication.BankId.UAParser.Test.csproj b/...uthentication.BankId.UAParser.Test/ActiveLogin.Authentication.BankId.UAParser.Test.csproj
@@ -5,9 +5,9 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.11.0" />
-    <PackageReference Include="Moq" Version="4.20.70" />
-    <PackageReference Include="xunit" Version="2.9.0" />
+    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.11.1" />
+    <PackageReference Include="Moq" Version="4.20.72" />
+    <PackageReference Include="xunit" Version="2.9.2" />
     <PackageReference Include="xunit.runner.visualstudio" Version="2.8.2">
       <PrivateAssets>all</PrivateAssets>
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>