-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PM-1743. update Postmark Ruby gem to support CustomTracking #156
base: main
Are you sure you want to change the base?
Conversation
FYI Tried to ask for approval from the postmark-ruby team but it doesn't appear on the list, so I asked for a review individually |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @J0SUEFDZ could you please remove the version and changelog updates from this PR? We typically update the version in a separate task.
Co-authored-by: Tomek M. <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd remove that change to lib/postmark/client.rb
from this PR but other than that it looks good to me 👍
…ActiveCampaign/postmark-gem into feature/PM-1734-custom-tracking
Thanks @tomek-ac. From my understanding, I can merge this without releasing, but I'll wait until the API is released to merge and release this. I'll follow the RELEASE.md instructions when I do it |
JIRA
What
verify_domain_custom_tracking
Why
With CustomTracking almost ready to ship to production, we needed to add support for CustomTracking in this gem.
Tests
Manual tests for all endpoints pertinent to Custom Tracking, specified in the JIRA ticket, are returning the expected outut.