Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: realpath on windows changed behavior in python 3.8 to expand mapped drive letters to their UNC path names #1856

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

cfxegbert
Copy link
Contributor

Fixes #1438

os.path.realpath on Python 3.8 Windows changed. When resolving mapped drive realpath returns the UNC path without the drive letter.

This pull restores the Python 3.7 Windows behavior of realpath being a wrapper around abspath. The behavior can be changed with the rezconfig setting windows_unc_path

@cfxegbert cfxegbert requested a review from a team as a code owner October 15, 2024 00:36
Copy link

codecov bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 59.31%. Comparing base (491497f) to head (0903ec3).
Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
src/rez/rezconfig.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1856      +/-   ##
==========================================
+ Coverage   59.30%   59.31%   +0.01%     
==========================================
  Files         126      126              
  Lines       17210    17217       +7     
  Branches     3015     3016       +1     
==========================================
+ Hits        10206    10212       +6     
- Misses       6319     6320       +1     
  Partials      685      685              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…ped drive letters to their UNC path names

Signed-off-by: Robert Minsk <[email protected]>
Signed-off-by: Robert Minsk <[email protected]>
Signed-off-by: Robert Minsk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Environment resolution uses UNC paths with Python 3.10, 3.7 was using mounted network drives.
1 participant