-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolved context unit testing #1749
Open
BryceGattis
wants to merge
15
commits into
AcademySoftwareFoundation:main
Choose a base branch
from
BryceGattis:resolved_context_unit_testing
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Resolved context unit testing #1749
BryceGattis
wants to merge
15
commits into
AcademySoftwareFoundation:main
from
BryceGattis:resolved_context_unit_testing
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: BryceGattis <[email protected]>
Signed-off-by: BryceGattis <[email protected]>
Signed-off-by: BryceGattis <[email protected]>
Signed-off-by: BryceGattis <[email protected]>
Signed-off-by: BryceGattis <[email protected]>
Signed-off-by: BryceGattis <[email protected]>
JeanChristopheMorinPerso
force-pushed
the
resolved_context_unit_testing
branch
from
May 12, 2024 20:45
77d156d
to
eaed6ed
Compare
Rebased in order to display the coverage information even if tests fail. |
Signed-off-by: Jean-Christophe Morin <[email protected]>
Signed-off-by: Jean-Christophe Morin <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1749 +/- ##
==========================================
+ Coverage 58.39% 58.52% +0.12%
==========================================
Files 126 126
Lines 17205 17209 +4
Branches 3519 3519
==========================================
+ Hits 10047 10071 +24
+ Misses 6491 6474 -17
+ Partials 667 664 -3 ☔ View full report in Codecov by Sentry. |
Sorry for the noise. I had to fix the coverage report... It should work now. |
…yceGattis/rez into resolved_context_unit_testing
…yceGattis/rez into resolved_context_unit_testing
Signed-off-by: BryceGattis <[email protected]>
Signed-off-by: BryceGattis <[email protected]>
Signed-off-by: BryceGattis <[email protected]>
Signed-off-by: BryceGattis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some more unit testing coverage for
resolved_context.py
TODO: