Update Rocky Linux 8.7 Build Instructions and Replace .tsh with .sh #384
Conversation
beatreichenbach
requested review from
bernie-laberge,
rogernelson and
geffrak
as code owners
|
|
| @@ -1,97 +1,64 @@ | |||
| #!/bin/tcsh -f | |||
There was a problem hiding this comment.
Can you do the other wrappers too?
There was a problem hiding this comment.
Is there any reason for other wrappers? Is there any system that doesn't use sh out of the box?
There was a problem hiding this comment.
I mean rvio.wrapper, py-interp.wrapper, etc.
There was a problem hiding this comment.
@geffrak I think I found all the tcsh scripts. Lmk what you think!
beatreichenbach
force-pushed
the
rockylinux8
branch
from
785a177 to
5420b99
Compare
beatreichenbach
changed the title
|
Hello @beatreichenbach, We would very much like to get this excellent work of yours for the .tcsh with .sh replacement. Thank you so much for your contribution ! |
beatreichenbach
force-pushed
the
rockylinux8
branch
from
23bde9e to
5d3b077
Compare
beatreichenbach
requested review from
eloisebrosseau and
cedrik-fuoco-adsk
as code owners
There was a problem hiding this comment.
This is Fantastic @beatreichenbach !
Thank you so much for your contribution and I apologize for the huge delay.
Sure, I can remove them, however I think it might be worth taking a look at how concise my update was vs what was there before. The previous docs also didn't help me build OpenRV in a docker container (meaning it was reproducible!) as I had to fix a bunch of stuff that wasn't in there. |
Linked issues
Related discussions
#346
#352
#90
#382
Summarize your change.
Adding documentation for Rocky Linux 8.7 Build.
Describe the reason for the change.
The existing documentation was lacking.
Describe what you have tested and on which operating system.
Rocky Linux 8.7
Add a list of changes, and note any that might need special attention during the review.
If possible, provide screenshots.